Desktop Plug: Dock section doesn't list themes

[Ivan]

In the new shell plug released and made by Tom Beckmann, in the dock section the theme choice is missing. And seems that text is not centered. I've attached a pic that show what i mean with 'it's not centered'

ProblemType: Bug
DistroRelease: elementary 0.2
Package: switchboard 0.9-0~r280+pkg13~precise1 [origin: LP-PPA-elementary-os-daily]
ProcVersionSignature: Ubuntu 3.2.0-29.46-generic-pae 3.2.24
Uname: Linux 3.2.0-29-generic-pae i686
NonfreeKernelModules: nvidia
ApportVersion: 2.0.1-0ubuntu11+elementary3~precise1+elementary3~precise1+elementary3~precise1
Architecture: i386
CrashDB: switchboard
Date: Mon Aug 13 18:09:04 2012
ExecutablePath: /usr/bin/switchboard
InstallationMedia: elementary OS 0.2 "Luna" - Build i386 LIVE Binary 20120628-19:27
ProcEnviron:
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: switchboard
UpgradeStatus: No upgrade log present (probably fresh install)

[Cody Garver (codygarver)]

Design team, is this bug valid or is it Won't Fix?

[Danielle Foré (danrabbit)]

Well the themes thing is definitely Wishlist and I'm not sure there's even a super clean way to implement a theme selector at this time. I'd push any wishlist items off until Luna +1 anyways.

But I feel like the center thing is pretty valid, even though it's a different report. So I've opened another ticket for that: Bug #1037203

[Ivan (iyia92)]

I remember that i've tried an early version of that .plug installed via bzr (that version that is in this video too http://www.youtube.com/watch?v=0XFt-de_t04&feature=player_embedded#!) and the 'theme' list was already implemented.

I don't know if this can help but i think that this mean it will not be so difficult to implement it again.

[Tom Beckmann (tombeckmann)]

That's the theme for the window decorations, not for plank, in the video.

[Ivan (iyia92)]

Yeah, i didn't say that video shows plank-theme list, i've said that in that video u've used the same version that i've tried via bzr.
But that's not the point..

[Ivan (iyia92)]

What about a merge of this https://code.launchpad.net/~elementary-os/+recipe/shell-plug-daily with this https://code.launchpad.net/~elementary-os/+recipe/appearance-plug-daily ?

easy and useful

[Tom Beckmann (tombeckmann)]

Originally I had all these options in the shell plug, but Dan asked me to remove them.

[Heath Paddock (heathbar)]

Here is a patch that adds a theme combo box to the Dock tab of the plug.

The combo box is populated by reading in the list of folders under /usr/share/plank/themes/

[Cody Garver (codygarver)]

Heath, thanks for the patch! Visit my profile https://launchpad.net/~codygarver and message me the email address associated with your launchpad account so that I can make the commit using your username.

[Cody Garver (codygarver)]

Heath, do this for me:

bzr branch lp:switchboard-plug-pantheon-shell fix-1036271
cd fix-1036271
# apply the patch: patch -p0 < ~/theme-selection.patch
bzr commit -m "Added support for changing dock theme to fix bug #1036271." --fixes=lp:1036271
bzr push lp:~heathbar/switchboard-plug-pantheon-shell/fix-1036271

# then visit https://code.launchpad.net/switchboard-plug-pantheon-shell/fix-1036271
# click Propose for merge

# then someone will review your code and its style

[Cody Garver (codygarver)]

This doc can help you a little with bzr: http://tiny.cc/dev-guide-draft