Multipart upload is required SLO in pipeline.

Bug #1396039 reported by Charles Hsu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Swift3
Fix Released
Undecided
Charles Hsu

Bug Description

Should we add a checkpoint to alert warning message to proxy.log?
If answer is yes, I cloud send the patch for it.

description: updated
Revision history for this message
Kota Tsuyuzaki (tsuyuzaki-kota) wrote :

It would be better as a temporally fix.

However, I would love to figure out how swift3 works when there is NOT slo in pipeline. I hope whole of requests against to multi-upload stuffs could get some error responses from backend swift caused from the lack of middleware. However, If some of them get success codes even though they actually did a unexpected behaviors, we have to fix them to deny the multi-part requests at swift3.

Did you already do those tests like above?

Revision history for this message
Charles Hsu (charles0126) wrote :

I already tested it, I can add patch for you review it.

No SLO:
Upload it's work. But when you try to download it, you got the xml file(S3 converted) of chunks. Even enable SLO after upload, you still can't get file back.
When you put xml(S3 converted) to swift, SLO will append metadata " X-Static-Large-Object: True", So if SLO is not in pipeline. The object doesn't have this metadata.

Changed in swift3:
assignee: nobody → Charles Hsu (charles0126)
Changed in swift3:
status: New → Confirmed
Changed in swift3:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift3 (master)

Fix proposed to branch: master
Review: https://review.openstack.org/138984

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift3 (master)

Reviewed: https://review.openstack.org/138984
Committed: https://git.openstack.org/cgit/stackforge/swift3/commit/?id=bd18bf100c4de78fa16909a1f16124163c544bd4
Submitter: Jenkins
Branch: master

commit bd18bf100c4de78fa16909a1f16124163c544bd4
Author: charz <email address hidden>
Date: Thu Dec 4 16:10:02 2014 +0800

    Fix multipart upload is required SLO in pipeline

    Multipart upload is enable by default, but it needs "slo" middleware
    support. If it isn't exist in pipeline, multipart upload still work, but
    download is not work(that's only xml file you can get.)

    If there is no "slo" in pipeline, all requests of multipart from client
    will be reject(return S3NotImplemented, 501 Not Implemented).

    Change-Id: If0a862d9f80cc806f5b0a8a0e87c70b17920f635
    Closes-Bug: #1396039

Changed in swift3:
status: In Progress → Fix Committed
Changed in swift3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.