Set ACL Error by Canned ACL
Bug #1382290 reported by
Kota Tsuyuzaki
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Swift3 |
Fix Released
|
Undecided
|
Kota Tsuyuzaki | ||
Bug Description
When we put bucket acl with X-AMZ-ACL header (i.e. without a XML body), always MalformedXMLError appears so we have to prevent that swift3 tries to translate from an empty string when the request body is empty.
I will push a patch to fix it soon.
| Changed in swift3: | |
| status: | New → In Progress |
| Changed in swift3: | |
| assignee: | nobody → Kota Tsuyuzaki (tsuyuzaki-kota) |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to swift3 (master) | #1 |
| Changed in swift3: | |
| status: | In Progress → Fix Committed |
| Changed in swift3: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 0af0afd6997c98f
Author: Kota Tsuyuzaki <email address hidden>
Date: Thu Oct 16 20:38:09 2014 -0700
Fix Canned ACL Error with Empty Body
Current acl controller do a double check both ACL header and
ACL body (xml).
However, if ACL body is not given but ACL header (X-AMZ-ACL) is
given as a canned ACL, current implementation always causes ACL
Error in parsing XML since the request body is empty even though
it should be handled as a correct request on acl controller.
In addition, if both of them are given, we have to UnexpectedContent
Exception according to S3 behavior.
This patch fixes to try to parse the request body only when
the request body is not empty. This pach also fixes to raise
if both ACL header and xml are given.
Change-Id: Ie23d5e3d94c47e
Closes-Bug: 1382290