LogProcessor fails first attempt to use it's InternalProxy

Bug #671236 reported by Travis W Kiel on 2010-11-05
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
High
John Dickinson
1.1
Undecided
Unassigned

Bug Description

The swift.stats.LogProcessor uses a wrapped method as its internal_proxy property. On first access it creates the InternalProxy object and stores it as _internal_proxy, yet it does not return it. This causes swift-log-stats-collector to throw an exception trying to use None as its proxy; it then hangs up.

LogProcessor should be updated to also return the object in the IF block,

    @property
    def internal_proxy(self):
        if self._internal_proxy is None:
            #### proxy instantiation code ###
            return self._internal_proxy
        else:
            return self._internal_proxy

Related branches

clayg (clay-gerrard) on 2010-11-05
Changed in swift:
importance: Undecided → High
assignee: nobody → John Dickinson (notmyname)
milestone: none → 1.2.0
clayg (clay-gerrard) on 2010-11-05
Changed in swift:
status: New → In Progress
Changed in swift:
status: In Progress → Fix Committed
Chuck Thier (cthier) on 2011-02-04
Changed in swift:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers