Scan for except Exception: where we meant except (Exception, Timeout):
Bug #758885 reported by
gholt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Object Storage (swift) |
Fix Released
|
Medium
|
Richard Hawkins |
Bug Description
We need to scan through our code looking for except Exception: clauses where we really mean except (Exception, Timeout):
We actually shouldn't make our own TimeoutException subclass of Timeout, as it has been indicated that some library routines have exception Exception: in them where it's not desirable to have them catching Timeouts.
description: | updated |
summary: |
- We should make our own TimeoutException that subclasses eventlet.Timeout - and Exception + Scan for except Exception: where we meant except (Exception, Timeout): |
Changed in swift: | |
assignee: | nobody → Varadharajan Mukundan (srinathsmn) |
tags: | added: low-hanging-fruit |
Changed in swift: | |
assignee: | nobody → Richard Hawkins (richard-hawkins) |
Changed in swift: | |
status: | Confirmed → Fix Released |
To post a comment you must log in.
removing Varadharajan Mukundan as asignee, as we've not heard anything in 3 years. If this was done in error, please re-assign.