account-reaper does not have an except/log global catchall

Bug #644075 reported by gholt
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Fix Released
Low
Unassigned

Bug Description

account-reaper does not have an except/log global catchall. Without such a catchall, uncaught exceptions send full tracebacks to stdout, which skips right over the "clean up common exceptions" code in the logger.

clayg (clay-gerrard)
Changed in swift:
assignee: nobody → clayg (clay-gerrard)
clayg (clay-gerrard)
Changed in swift:
assignee: clayg (clay-gerrard) → nobody
Changed in swift:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Juan J. Martínez (jjmartinez) wrote :

I'm getting account-reaper errors such as:

 - account-reaper STDOUT: error: [Errno 111] ECONNREFUSED / csstore2 account-reaper STDOUT: Removing descriptor: <NUMBER_HERE>
 - account-reaper STDOUT: Timeout: 10 seconds
 - csstore2 account-reaper STDOUT: BadStatusLine / csstore2 account-reaper STDOUT: Removing descriptor: <NUMBER_HERE>

All of them on direct_delete_object.

I see this bug report it's just to catch those, but... is it possible that there errors can kill the performance of a 4 storage node cluster? Should a report a new bug for that?

Thanks.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/8131

Changed in swift:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.openstack.org/8131
Committed: http://github.com/openstack/swift/commit/63ad27cd5fdd5cce3b989974bbc1c70c19ea58a4
Submitter: Jenkins
Branch: master

commit 63ad27cd5fdd5cce3b989974bbc1c70c19ea58a4
Author: Greg Lange <email address hidden>
Date: Mon Jun 4 17:04:11 2012 +0000

    Added global catchall to account-reaper.

    bug 644075

    Change-Id: I75c73a42ddd8654a39a2fd82320941199bee4363

Changed in swift:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in swift:
milestone: none → 1.6.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.