executables should be more DRY
Bug #611118 reported by
Mike Barton
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Object Storage (swift) |
Fix Released
|
Medium
|
Chuck Thier | ||
Bug Description
The executables under bin/ that launch non-WSGI daemons have a lot of repetitive code to read configs, create loggers, replace stdout, drop privileges, etc. That should be refactored so they contain less code and make fewer decisions themselves.
Related branches
lp:~cthier/swift/drybins
- gholt (community): Approve
-
Diff: 1152 lines (+241/-320)26 files modifiedbin/swift-account-auditor (+1/-30)
bin/swift-account-reaper (+1/-30)
bin/swift-account-replicator (+8/-25)
bin/swift-container-auditor (+1/-30)
bin/swift-container-replicator (+8/-24)
bin/swift-container-updater (+1/-23)
bin/swift-object-auditor (+1/-27)
bin/swift-object-replicator (+5/-44)
bin/swift-object-updater (+1/-24)
etc/proxy-server.conf-sample (+2/-2)
swift/account/auditor.py (+5/-4)
swift/account/reaper.py (+9/-7)
swift/account/replicator.py (+26/-0)
swift/common/daemon.py (+60/-0)
swift/common/db_replicator.py (+7/-6)
swift/common/utils.py (+2/-0)
swift/container/auditor.py (+5/-3)
swift/container/replicator.py (+25/-0)
swift/container/updater.py (+7/-5)
swift/obj/auditor.py (+8/-6)
swift/obj/replicator.py (+34/-8)
swift/obj/updater.py (+6/-4)
test/unit/common/test_db_replicator.py (+2/-2)
test/unit/container/test_updater.py (+7/-7)
test/unit/obj/test_replicator.py (+3/-3)
test/unit/obj/test_updater.py (+6/-6)
| Changed in swift: | |
| assignee: | nobody → Chuck Thier (cthier) |
| status: | New → In Progress |
| Changed in swift: | |
| status: | In Progress → Fix Committed |
| Changed in swift: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
