Unmaintained dependency: netifaces

[Tim Burke]

For more than ten years (since https://opendev.org/openstack/swift/commit/e0987d60 merged) Swift has had a dependency on netifaces -- we use it to determine a node's own IP addresses when using servers_per_port, as the ports to bind need to be looked up in the ring(s).

Roughly two years ago, however, that project was archived: see the notice at https://github.com/al45tair/netifaces

This has also been discussed on the ML: https://lists.openstack.org/pipermail/openstack-discuss/2023-April/033261.html

[Tim Burke (1-tim-z)]

One alternative brought up is https://pypi.org/project/ifaddr/

I wonder if we actually need all the features offered, though -- we don't actually care about the network adapters themselves. Perhaps we could use ctypes to call getifaddrs() ourselves; I believe it should be available on all the platforms we care about. Even if it isn't, we could still fall back to netifaces for now, with a warning about how that fallback behavior will be removed in the future -- and encourage operators to report it if they see the warning.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/swift/+/883035

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/swift/+/873222
Committed: https://opendev.org/openstack/swift/commit/23fa18d3021fb44d8b4dd81890d9c355eed9426f
Submitter: "Zuul (22348)"
Branch: master

commit 23fa18d3021fb44d8b4dd81890d9c355eed9426f
Author: Tim Burke <email address hidden>
Date: Mon May 22 10:37:12 2023 -0700

    Remove hard dependency on netifaces

    The project was archived in 2021, and we can fairly easily replace it
    with some ctypes code to call getifaddrs ourselves.

    Be willing to fall back to netifaces (with a warning) in case getifaddrs
    is not available, but I'm fairly certain it will be for all platforms we
    support.

    Could maybe use some more testing on big-endian arches / BSDs, but an
    attempt was at least made at supporting them.

    Partial-Bug: #2019233
    Change-Id: I1189a60204cf96c291619f8d8ec957ed8a5be1ce