Flakey unit test: test/unit/obj/test_diskfile.py::TestECDiskFileManager::test_cleanup_ondisk_files_commit_window

Bug #2017024 reported by Tim Burke
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Fix Released
Undecided
Unassigned

Bug Description

I've seen failures like

test/unit/obj/test_diskfile.py:1152: in _test_cleanup_ondisk_files
    self.assertEqual(expected_after_cleanup, after_cleanup, errmsg)
E AssertionError: Items in the first set but not the second:
E '1681926533.94253#1.data' : expected ['1681926533.94253#1.data', '1681926634.94254#2.data'], got ['1681926634.94254#2.data'] for test [('1681926533.94253#1.data', True), ('1681926634.94254#2.data', True), ('1681926533.94253.meta', False), ('1681926533.94253.ts', False)]

lately -- not all the time, but often enough to be annoying.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/swift/+/881142

Changed in swift:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.opendev.org/c/openstack/swift/+/881142
Committed: https://opendev.org/openstack/swift/commit/105727bc8961e1cd263d0edd00c7f9ce46dacd2c
Submitter: "Zuul (22348)"
Branch: master

commit 105727bc8961e1cd263d0edd00c7f9ce46dacd2c
Author: Tim Burke <email address hidden>
Date: Thu Apr 20 12:51:03 2023 -0700

    tests: Fix test_cleanup_ondisk_files_commit_window

    `much_older` has to be much older than `older`, or the test gets
    flakey. See

    - test_cleanup_ondisk_files_reclaim_non_data_files,
    - test_cleanup_ondisk_files_reclaim_with_data_files, and
    - test_cleanup_ondisk_files_reclaim_with_data_files_legacy_durable

    for a more standard definition of "much_older".

    Closes-Bug: #2017024
    Change-Id: I1eaa501827f4475ddc0c20d82cf0a6d4a5e98f75

Changed in swift:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/swift 2.32.0

This issue was fixed in the openstack/swift 2.32.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.