Malformed CompleteMultipartUpload request can 500

[Tim Burke]

I was testing out some MPU workflows and got a bunch of 500s when I ran

   aws s3api complete-multipart-upload --bucket bucket --key key \
   --upload-id $UPLOADID --multipart-upload "Parts=[{ETag=$ETAG,PartNumber=1}]"

Trouble was that I didn't have ETAG set, but that still should be better-handled:

Jun 11 19:48:48 saio proxy-server: object of type 'NoneType' has no len():
Traceback (most recent call last):
  File "/vagrant/swift/swift/common/middleware/s3api/s3api.py", line 292, in __call__
    resp = self.handle_request(req)
  File "/vagrant/swift/swift/common/middleware/s3api/s3api.py", line 330, in handle_request
    res = handler(req)
  File "/vagrant/swift/swift/common/middleware/s3api/controllers/base.py", line 60, in wrapped
    return func(self, req)
  File "/vagrant/swift/swift/common/middleware/s3api/controllers/base.py", line 72, in check_container
    return func(self, req)
  File "/vagrant/swift/swift/common/middleware/s3api/controllers/multi_upload.py", line 633, in POST
    if len(etag) != 32 or any(c not in '0123456789abcdef'
TypeError: object of type 'NoneType' has no len() (txn: tx0c4974454044483c9d9c2-005ee28aa0) (client_ip: 127.0.0.1)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/swift/+/865348
Committed: https://opendev.org/openstack/swift/commit/4cba97d7b66d3267a3e899ce332989c897ae15a8
Submitter: "Zuul (22348)"
Branch: master

commit 4cba97d7b66d3267a3e899ce332989c897ae15a8
Author: Ashwin Nair <email address hidden>
Date: Tue Nov 22 15:22:50 2022 -0800

    Malformed CompleteMultipartUpload request should 400

    Closes-Bug: #1883172
    Change-Id: Ie44288976ac5a507c27bd175c5f56c9b0bd04fe0

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/swift 2.31.0 release.