Encourage the use of static device names in fstab

Bug #1817966 reported by Romain LE DISEZ
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Fix Released
Undecided
Michele Valsecchi

Bug Description

Using unstable name devices (eg: /dev/sdb) for Swift in /etc/fstab is a risky idea.

The documentation does not encourage the use of stable name devices, and it also shows[1] the use of unstable device names.

The documentation needs to encourage the use of stable device names. Presumably one of:
- label
- uuid
- id

[1] https://github.com/openstack/swift/blob/0a993437d1dd837be80a036b1525a3195c86a10d/doc/source/install/storage-install-ubuntu-debian.rst

Changed in swift:
status: New → Confirmed
tags: added: low-hanging-fruit
Changed in swift:
assignee: nobody → Michele Valsecchi (mvalsecc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.opendev.org/716926

Changed in swift:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.opendev.org/716926
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=875a142980b77f2b6eacb3a4d7b8bcb8bb29eacd
Submitter: Zuul
Branch: master

commit 875a142980b77f2b6eacb3a4d7b8bcb8bb29eacd
Author: Michele Valsecchi <email address hidden>
Date: Thu Apr 2 19:44:14 2020 +0900

    docs: Encourage usage of UUID inside /etc/fstab in examples

    Update doc examples to use explicit UUID of devices, instead of using
    unstable device names.

    Change-Id: I3a2eb7bbe4b4091d2567897904d939df1df6b251
    Closes-Bug: #1817966

Changed in swift:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (feature/losf)

Fix proposed to branch: feature/losf
Review: https://review.opendev.org/720819

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (feature/losf)
Download full text (4.9 KiB)

Reviewed: https://review.opendev.org/720819
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=4e594b43d03ac52eb5dbff9d357e63f07d1f28c8
Submitter: Zuul
Branch: feature/losf

commit 0c37da906e053964df24910cca364899aac91899
Author: OpenStack Proposal Bot <email address hidden>
Date: Thu Apr 16 09:55:40 2020 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

    Change-Id: I4022f269a6066a06bb9f8fa9b6a2d52653e7966e

commit 9a7ab4b3b26281d0d55d2e9f6a39cd59e1c637fe
Author: OpenStack Proposal Bot <email address hidden>
Date: Sat Apr 11 08:43:31 2020 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://docs.openstack.org/i18n/latest/reviewing-translation-import.html

    Change-Id: Iebcfa847fbacdedb6d9cf1acd17188f7beb12952

commit 415011e162fad469801e5f5e88a11960f638bdbf
Author: Romain de Joux <email address hidden>
Date: Tue Apr 7 22:03:11 2020 +0200

    s3api: Propagate backend PATH_INFO in environ for other middleware

    Use swift.backend_path entry in wsgi environment to propagate
    backend PATH_INFO.

    Needed by ceilometermiddleware to extract account/container info
    from PATH_INFO, patch: https://review.opendev.org/#/c/718085/

    Change-Id: Ifb3c6c30835d912c5ba4b2e03f2e0b5cb392671a

commit 875a142980b77f2b6eacb3a4d7b8bcb8bb29eacd
Author: Michele Valsecchi <email address hidden>
Date: Thu Apr 2 19:44:14 2020 +0900

    docs: Encourage usage of UUID inside /etc/fstab in examples

    Update doc examples to use explicit UUID of devices, instead of using
    unstable device names.

    Change-Id: I3a2eb7bbe4b4091d2567897904d939df1df6b251
    Closes-Bug: #1817966

commit 668242c4229d8bdb0f1b2d3183efcc33c6b67154
Author: Tim Burke <email address hidden>
Date: Fri Apr 3 10:44:25 2020 -0700

    pep8: Turn on E305

    Change-Id: Ia968ec7375ab346a2155769a46e74ce694a57fc2

commit 96b56519bf5756022d495aedc0033cd44e0e3267
Author: Andreas Jaeger <email address hidden>
Date: Fri Apr 3 10:53:34 2020 +0200

    Update hacking for Python3

    The repo is Python using both Python 2 and 3 now, so update hacking to
    version 2.0 which supports Python 2 and 3. Note that latest hacking
    release 3.0 only supports version 3.

    Fix problems found.

    Remove hacking and friends from lower-constraints, they are not needed
    for installation.

    Change-Id: I9bd913ee1b32ba1566c420973723296766d1812f

commit bbea88cb1a2f11d8609e4d43ac57f80717576ae8
Author: Romain de Joux <email address hidden>
Date: Mon Oct 7 18:02:21 2019 +0200

    Extend MemcacheRing.delete() API to manage server_key

    Memcachering provided set_multi/get_multi to set/get list of key on an
    unique memcached server selected in ring with server_key value. But
    current api doesn't allow to deleted value save with set_multi.

    This change add a server_key optional keyword to delete method to allow
    to delete entry in the memcached selected with se...

Read more...

tags: added: in-feature-losf
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.