Ring reload normalization should be moved to RingData deserialization

Bug #1696837 reported by clayg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Fix Released
Wishlist
Rajat Sharma

Bug Description

There's some code to handle normalization of legacy data during Ring [re]loading [1].

It should be moved to RingData with the other normalization [2] so e.g. metadata_only=True deserialization can pickup a normalized list of device info dictionaries.

1. https://github.com/openstack/swift/blob/d46b0f29f9e023249b582bfa1fbf80cb8f577182/swift/common/ring/ring.py#L203

2. https://github.com/openstack/swift/blob/d46b0f29f9e023249b582bfa1fbf80cb8f577182/swift/common/ring/ring.py#L46

Rajat Sharma (tajar29)
Changed in swift:
assignee: nobody → Rajat Sharma (tajar29)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/swift/+/881671

Changed in swift:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.opendev.org/c/openstack/swift/+/881671
Committed: https://opendev.org/openstack/swift/commit/b8f0a0ed5cf9dc79ed29073c15c9996cb55e4efb
Submitter: "Zuul (22348)"
Branch: master

commit b8f0a0ed5cf9dc79ed29073c15c9996cb55e4efb
Author: Tim Burke <email address hidden>
Date: Wed Apr 26 15:34:04 2023 -0700

    ring: Centralize device normalization

    This puts replication info in antique rings loaded with metadata_only=True.

    Closes-Bug: #1696837
    Change-Id: Idf263a7f7a984a1307bd74040ac8f8bb1651bc79

Changed in swift:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/swift 2.32.0

This issue was fixed in the openstack/swift 2.32.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.