RingBuilder.save isn't atomic

Bug #1693149 reported by clayg on 2017-05-24
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)

Bug Description

RingBuilder's are big-ish. We're serializing a non trival data structure while the file handle is open and writing directly into the in-place file - no ideal.

It would be *much* better to write a temporary file - then flush and fsync - then rename.

clayg (clay-gerrard) wrote :
Changed in swift:
importance: Undecided → Wishlist
clayg (clay-gerrard) wrote :

both cases in that diff where it uses self.path that should just be builder_file or something reasonable - you get the idea.

Tim Burke (1-tim-z) on 2017-09-12
Changed in swift:
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers