Delete account with InternalClient

[clayg]

The internal client module is missing a delete_account method, you can roll your own with make_request [1]

But it'd be nice if it was there and easy to use.

1. https://gist.github.com/clayg/1813aeb207a2411c823a5e5af32e169b

[HCLTech-SSW (hcltech-ssw)]

As this can be done using the below set of commands:

a) Issue the GET request to get the authentication token for the admin user, using the following command.

curl -v -H 'X-Storage-User: admin:admin' -H 'X-Storage-Pass: admin' http://<ip address>:8080/auth/v1.0

Output is X-Auth-Token.

b) Issue the delete request for the specific account by passing the account storage URL.

curl -X DELETE -H 'X-Auth-Token: <Token from step a above>' http://<ip address>:8080/v1/AUTH_<Name of the account to be deleted.>

There is No Output from this command, but the account get deleted.

As there is the provision to delete the account using cURL, still there is the need to provide the method into the internal client library??

[clayg (clay-gerrard)]

yes, I think the bug is specifically for adding the method to the inernal client module - for parity with other methods like delete_container [1] and delete_object [2]

1. https://github.com/openstack/swift/blob/834b733d297d08ef8bc5e09c52653f9292d61f75/swift/common/internal_client.py#L462
2. https://github.com/openstack/swift/blob/834b733d297d08ef8bc5e09c52653f9292d61f75/swift/common/internal_client.py#L558

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/693305
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=7f6b09dc930706d63a943dc239dff84ddae52014
Submitter: Zuul
Branch: master

commit 7f6b09dc930706d63a943dc239dff84ddae52014
Author: SeongSoo Cho <email address hidden>
Date: Thu Nov 7 15:32:21 2019 +0800

    Add delete_account in InternalClient

    Currently, The internal client module is missing a delete_account method.
    I added a delete_account in InternalClient

    Change-Id: I97cb090820b4099944ba49eaeb5b02f9bbcf1d58
    Closes-Bug: #1680377

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/swift 2.24.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: feature/losf
Review: https://review.opendev.org/713632

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/713632
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=79bd2e59e5c15ee84814ec1c4f0893176ba79412
Submitter: Zuul
Branch: feature/losf

commit f2ffd900593db2829a39a073f0c033d82985c40f
Author: Clay Gerrard <email address hidden>
Date: Fri Feb 28 11:09:51 2020 -0600

    Apply limit to list versioned containers

    Change-Id: I28e062273d673c4f07cd3c5da088aa790b77a599
    Closes-Bug: #1863841

commit dc40779307095b8d0b2761b77b9cb2904ec721ae
Author: Clay Gerrard <email address hidden>
Date: Fri Feb 28 10:00:25 2020 -0600

    Use float consistently for proxy timeout settings

    Change-Id: I433c97df99193ec31c863038b9b6fd20bb3705b8

commit 55049beda5b9d7038a3604a87f28312d7702ccb2
Author: Tim Burke <email address hidden>
Date: Fri Feb 28 18:59:32 2020 -0800

    tests: Use timedelta to adjust dates, not string manipulations

    Change-Id: I8f65ccd7f2a79d5b877bfbef0274fb7857e21391

commit 3b65a5998cc921d2763cf1a9ec1e40b88491262d
Author: Tim Burke <email address hidden>
Date: Wed Jan 10 06:16:41 2018 +0000

    Fix up some Content-Type handling in account/container listings

    Update content type on 204 (not just 200) to properly handle HEAD
    requests from xml/txt listings.

    Add "Vary: Accept" header to listings, since otherwise, browsers may
    serve the wrong content type from cache (even though we *would have*
    sent the *right* type if it actually sent the request).

    Change-Id: Iaa333aaca36a8dc2df65d38ef2173e3a6e2000ee

commit ecca23eb806e11cf6517f0456483da7a065350a8
Author: Clay Gerrard <email address hidden>
Date: Fri Feb 21 15:33:21 2020 -0600

    Extend eventlet_debug logging to GreenAsyncPile

    Change-Id: Ibd9fe5c9a1e75b86eb7d540594d5cf516758e17e

commit 0fb3371484f1d0f629d0b0e33f6aafbff0e43ee9
Author: Sam Morrison <email address hidden>
Date: Tue Feb 18 10:17:50 2020 +1100

    Delay importing swiftclient until after monkey-patching

    Commit message below partly copied from nova:

    Eventlet monkey patching should be as early as possible

    We were seeing infinite recursion opening an ssl socket when running
    various combinations of python3, eventlet, and urllib3. It is not
    clear exactly what combination of versions are affected, but for
    background there is an example of this issue documented here:

    https://github.com/eventlet/eventlet/issues/371

    The immediate cause in swift's case was that we were calling
    eventlet.monkey_patch() after importing swiftclient (which imported
    requests, which finally imported urllib3).

    We only use the imported function in one place, however; hold off on
    importing until we actually need it to ensure that monkey patching
    happens first. Note that we *don't* want to monkey-patch at import time,
    as we've previously had bugs related to import-time side-effects.

    Change-Id: I24f4bcc3d62dc37fd9559032bfd25f5b15f98745
    Closes-bug: #1863680
    Related-bug: #1380815

commit a5afe767581d2cb97cf3690067e6d626c7682c2c
Author: Tim Burke <email address hidden>
Date: Wed Feb 19 10:09:49 2020 -0800

    Revert "Make roll...