Comment 4 for bug 1678018

Revision history for this message
Alistair Coles (alistair-coles) wrote :

WRT Clay's comment #1, the _full_path method will blow up when path arg has non-ascii chars because the node dict items are unicode, so the string format will try to coerce the path to unicode.

The node dict is all unicode because it is loaded using json.loads() in RingData.load()

The call to _full_path in get_response was until recently only made when there was a warning to log, but now _full_path is called unconditionally at start of get_response [1].

[1] https://review.openstack.org/#/c/219165/60/swift/obj/reconstructor.py@222