OpenStack Object Storage (swift)

Subclasses don't strictly follow the inheritance

Bug #1676694 reported by junboli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Invalid
Undecided
junboli

Bug Description

Subclasses

  swift/account/auditor.py::AccountAuditor

  swift/container/auditor.py::ContainerAuditor
  swift/container/updator.py::ContainerUpdater

  swift/obj/auditor.py::ObjectAuditor
  swift/obj/updator.py::ObjectUpdater
  swift/obj/replicator.py::ObjectReplicator
  swift/obj/reconstructor.py::ObjectReconstructor

All thess subclasses are all inherited from Daemon
So, "super(SubClass, self).__init__(foo, bar)" is recommended.

junboli (junboli)
Changed in swift:
status: New → In Progress
assignee: nobody → junboli (junboli)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/450523

Alistair Coles (alistair-coles)
Changed in swift:
status: In Progress → Incomplete
Revision history for this message
Alistair Coles (alistair-coles) wrote :

Why do you say that calling the superclass __init__ is "recommended"? It is not a requirement. It may be that there has been a deliberate choice not to call it. In this case, does the superclass method provide useful behaviour for the subclass to inherit (or conflicting behaviour)?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on swift (master)

Change abandoned by junboli (<email address hidden>) on branch: master
Review: https://review.openstack.org/450523

junboli (junboli)
Changed in swift:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.