Remove log translations

Bug #1674543 reported by yfzhao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
In Progress
Undecided
yfzhao

Bug Description

Log messages are no longer being translated. This removes all use of
the _LE, _LI, and _LW translation markers to simplify logging and to
avoid confusion with new contributions.

See:
http://lists.openstack.org/pipermail/openstack-i18n/2016-November/002574.html
http://lists.openstack.org/pipermail/openstack-dev/2017-March/113365.html

yfzhao (yfzhao)
Changed in swift:
assignee: nobody → yfzhao (yfzhao)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.openstack.org/504341
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=f192f51d371e489f74f2bd71c811a4ce8d53afa1
Submitter: Zuul
Branch: master

commit f192f51d371e489f74f2bd71c811a4ce8d53afa1
Author: Tim Burke <email address hidden>
Date: Fri Sep 15 06:15:40 2017 +0000

    Have check_drive raise ValueError on errors

    ...which helps us differentiate between a drive that's not mounted vs.
    not a dir better in log messages. We were already doing that a bit in
    diskfile.py, and it seems like a useful distinction; let's do it more.

    While we're at it, remove some log translations.

    Related-Change: I941ffbc568ebfa5964d49964dc20c382a5e2ec2a
    Related-Change: I3362a6ebff423016bb367b4b6b322bb41ae08764
    Change-Id: Ife0d34f9482adb4524d1ab1fe6c335c6b287c2fd
    Partial-Bug: 1674543

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/611686
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=baf18edc00851f6749a40794587ca14a52135bf3
Submitter: Zuul
Branch: master

commit baf18edc00851f6749a40794587ca14a52135bf3
Author: Tim Burke <email address hidden>
Date: Thu Oct 18 10:35:31 2018 -0700

    Clean up account-reaper a bit

    - Drop the (partial) logging translation
    - Save our log concatenations until the end
    - Stop encoding object names; direct_client is happy to take Unicode
    - Remove a couple loop breaks that were only used by tests

    Change-Id: I4a4f301a7a6cb0f217ca0bf8712ee0291bbc14a3
    Partial-Bug: #1674543

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (feature/losf)

Fix proposed to branch: feature/losf
Review: https://review.openstack.org/648245

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (feature/losf)
Download full text (11.9 KiB)

Reviewed: https://review.openstack.org/648245
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=6afc1130fd753306d64745c9bee7712182b273d3
Submitter: Zuul
Branch: feature/losf

commit 89e5927f7dd94fc28b3847944eb7dd227d516fa8
Author: Thiago da Silva <email address hidden>
Date: Tue Mar 26 10:46:02 2019 -0400

    Fix mocking time

    When running on Centos the side_effect was returning a MagicMock
    object instead of the intended int.

    Change-Id: I73713a9a96dc415073a637d85a40304021f76072

commit 50715acb1838fbde628e447e7b02545ce8469180
Author: OpenStack Release Bot <email address hidden>
Date: Mon Mar 25 17:07:54 2019 +0000

    Update master for stable/stein

    Add file to the reno documentation build to show release notes for
    stable/stein.

    Use pbr instruction to increment the minor version number
    automatically so that master versions are higher than the versions on
    stable/stein.

    Change-Id: I6109bff3227f87d914abf7bd1d76143aaf91419d
    Sem-Ver: feature

commit 179fa7ccd4d6faeacc989715887b69f9422a17b2
Author: John Dickinson <email address hidden>
Date: Mon Mar 18 17:09:31 2019 -0700

    authors/changelog update for 2.21.0 release

    Change-Id: Iac51a69c71491e5a8db435aae396178a6c592c73

commit 64eec5fc93eb670e581cbb3a6dedb6a7aa501e99
Author: Tim Burke <email address hidden>
Date: Thu Mar 7 14:36:02 2019 -0800

    Fix how we UTF-8-ify func tests

    I noticed while poking at the DLO func tests that we don't actually use
    non-ascii chars when we set up the test env.

    By patching the create name function earlier (in SetUpClass) we can
    ensure we get some more interesting characters in our object names.

    Change-Id: I9480ddf74463310aeb11ad876b79527888d8c871

commit fe3a20f2e4b745bf7d81f9bda97082b593e8794a
Author: Tim Burke <email address hidden>
Date: Tue Mar 19 14:52:19 2019 -0700

    Remove uncalled function

    Change-Id: Ica67815f0ddf4b00bce1ffe183735490c7f7c0b5
    Related-Change: I5629de9f2e9b2331ed3f455d253efc69d030df72

commit adc568c97f5b30d9d4628eaf448f81d736ad4e51
Author: John Dickinson <email address hidden>
Date: Fri Mar 15 15:18:36 2019 -0700

    Fix bulk responses when using xml and Expect 100-continue

    When we fixed bulk response heartbeating in https://review.openstack.org/#/c/510715/,
    code review raised the issue of moving the xml header down to after the
    early-exit clauses. At the time, it didn't seem to break anything, so
    it was left in place. However, that insight was correct.

    The purpose of the earlier patch was to force eventlet to use chunked
    transfer encoding on the response in order to prevent eventlet from
    buffering the whole response, thus defeating the purpose of the
    heartbeat responses.

    Moving the first line of the body lower (ie after the early exit
    checks), allows other headers in a chunked transfer encoding response
    to be appropriately processed before sending the headers. Sending the
    xml declaration early causes it to get intermingled in the 100-continue
    protocol, thus breaking the chunked transfer encoding semantics.

    Closes-Bug: #1819...

tags: added: in-feature-losf
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.opendev.org/742549
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=0dbf3d0a954522e5f6cc529c6da961ef2f87991d
Submitter: Zuul
Branch: master

commit 0dbf3d0a954522e5f6cc529c6da961ef2f87991d
Author: Tim Burke <email address hidden>
Date: Wed Jul 22 15:43:21 2020 -0700

    Actually interpolate error message

    Also, drop translation for the error message to improve search-ability.

    Change-Id: I24e417ca7500bc9455d5307e6712517c75b2cd25
    Partial-Bug: 1674543

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/swift/+/749810
Committed: https://opendev.org/openstack/swift/commit/f1c411c5299e77a595b57f36927485fc6f702411
Submitter: "Zuul (22348)"
Branch: master

commit f1c411c5299e77a595b57f36927485fc6f702411
Author: Tim Burke <email address hidden>
Date: Thu Sep 3 11:18:02 2020 -0700

    proxy: Remove a bunch of logging translations

    Change-Id: I2ffacdbd70c72e091825164da24cc87ea67721d7
    Partial-Bug: #1674543

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/swift/+/819739

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/swift/+/819741

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/swift/+/819742

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.opendev.org/c/openstack/swift/+/819742
Committed: https://opendev.org/openstack/swift/commit/5979b6e15f8008e14ba06c6986913ab08d4fc4c2
Submitter: "Zuul (22348)"
Branch: master

commit 5979b6e15f8008e14ba06c6986913ab08d4fc4c2
Author: Tim Burke <email address hidden>
Date: Mon Nov 29 17:19:17 2021 -0800

    account: Remove logging translations

    Change-Id: I1c415ec6fcfe426f71267c2fb7d714c2d84e0014
    Partial-Bug: #1674543

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/swift/+/819741
Committed: https://opendev.org/openstack/swift/commit/7cfacbb25888bc3e1cb7759ab800744a1b7792e8
Submitter: "Zuul (22348)"
Branch: master

commit 7cfacbb25888bc3e1cb7759ab800744a1b7792e8
Author: Tim Burke <email address hidden>
Date: Mon Nov 29 17:17:48 2021 -0800

    container: Remove a bunch of logging translations

    Change-Id: I849d08af90c59cf96ad205f651d8a179f354f0ac
    Partial-Bug: #1674543

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.opendev.org/c/openstack/swift/+/819739
Committed: https://opendev.org/openstack/swift/commit/80d025233fe2faa73e0c1e07bd50f7cc657fe685
Submitter: "Zuul (22348)"
Branch: master

commit 80d025233fe2faa73e0c1e07bd50f7cc657fe685
Author: Tim Burke <email address hidden>
Date: Mon Nov 29 16:53:28 2021 -0800

    object: Remove a bunch of logging translations

    Change-Id: Id6020345c11834a3e133f720a72b3787b1733bba
    Partial-Bug: #1674543

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/swift/+/823423

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/swift/+/864775

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.opendev.org/c/openstack/swift/+/864775
Committed: https://opendev.org/openstack/swift/commit/26c86c0e4103a6bb9d33b47c6a566d5e8230f9bd
Submitter: "Zuul (22348)"
Branch: master

commit 26c86c0e4103a6bb9d33b47c6a566d5e8230f9bd
Author: Alistair Coles <email address hidden>
Date: Wed Nov 16 18:19:51 2022 +0000

    db_auditor: remove logging translation

    Change-Id: Idc3689755b635a8492dff9c1e7f3ddf7eb3946d9
    Partial-Bug: #1674543

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers