swift-get-nodes ValueError on non-legacy rings

[clayg]

Using the -P option the `objects-1` dir is correct:

ubuntu@saio:~$ swift-get-nodes -P ec -p 673

Account None
Container None
Object None

Partition 673
Hash None

</snip>

Use your own device location of servers:
such as "export DEVICE=/srv/node"
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb14/objects-1/673"
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb13/objects-1/673"
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb10/objects-1/673"
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb11/objects-1/673"
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb2/objects-1/673"
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb5/objects-1/673"
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb12/objects-1/673" # [Handoff]
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb15/objects-1/673" # [Handoff]
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb4/objects-1/673" # [Handoff]
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb7/objects-1/673" # [Handoff]
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb8/objects-1/673" # [Handoff]
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb9/objects-1/673" # [Handoff]

If specified policy by ring, it's wrong:

ubuntu@saio:~$ swift-get-nodes /etc/swift/object-1.ring.gz -p 673

Account None
Container None
Object None

Partition 673
Hash None

<snip>

Use your own device location of servers:
such as "export DEVICE=/srv/node"
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb14/objects-/673"
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb13/objects-/673"
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb10/objects-/673"
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb11/objects-/673"
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb2/objects-/673"
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb5/objects-/673"
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb12/objects-/673" # [Handoff]
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb15/objects-/673" # [Handoff]
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb4/objects-/673" # [Handoff]
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb7/objects-/673" # [Handoff]
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb8/objects-/673" # [Handoff]
ssh 127.0.0.1 "ls -lah ${DEVICE:-/srv/node*}/sdb9/objects-/673" # [Handoff]

Oh, it also blows up:

ubuntu@saio:~$ swift-get-nodes /etc/swift/object-1.ring.gz a c o
Traceback (most recent call last):
  File "/usr/local/bin/swift-get-nodes", line 6, in <module>
    exec(compile(open(__file__).read(), __file__, 'exec'))
  File "/vagrant/swift/bin/swift-get-nodes", line 66, in <module>
    print_item_locations(ring, ring_name, *args, **vars(options))
  File "/vagrant/swift/swift/cli/info.py", line 572, in print_item_locations
    policy_index = int(ring_name.rsplit('-', 1)[1])
ValueError: invalid literal for int() with base 10: ''

[YongWang (chenyongwang)]

change swift-get-nodes ring_name = basename(ring_path)[:len('ring.gz')] to ring_name = basename(ring_path)[:-len('.ring.gz')] will resolve this problem.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/447183

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/447183
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=99412d48309e071eb190a2f4735df577a22cdb87
Submitter: Jenkins
Branch: master

commit 99412d48309e071eb190a2f4735df577a22cdb87
Author: cheng <email address hidden>
Date: Sat Mar 18 03:43:32 2017 +0000

    fix get ring name

    replace ring_name = basename(ring_path)[:len('ring.gz')]
    with ring_name = basename(ring_path)[:-len('.ring.gz')]

    Change-Id: I741e46d116c8fc7c2e91a51da4284302eec3aa41
    Closes-bug: #1668736

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/swift 2.14.0 release.