String interpolation should be handled by logger

Bug #1661262 reported by Gábor Antal on 2017-02-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Undecided
Akihiro Motoki
OpenStack Object Storage (swift)
Undecided
Gábor Antal
python-heatclient
Fix Released
Undecided
Gábor Antal
python-ironicclient
Fix Released
Undecided
Gábor Antal
python-neutronclient
Undecided
Akihiro Motoki

Bug Description

According to [1] guideline, strings should be interpolated by the logger.

    # WRONG
    LOG.info(_LI('some message: variable=%s') % variable)

    # RIGHT
    LOG.info(_LI('some message: variable=%s'), variable)

[1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

Changed in swift:
assignee: nobody → Gábor Antal (gabor.antal)

Fix proposed to branch: master
Review: https://review.openstack.org/428159

Changed in swift:
status: New → In Progress

Reviewed: https://review.openstack.org/428159
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=5817f804fddaa1fd7642d774c0435148fb2067b6
Submitter: Jenkins
Branch: master

commit 5817f804fddaa1fd7642d774c0435148fb2067b6
Author: Gábor Antal <email address hidden>
Date: Thu Feb 2 15:19:13 2017 +0100

    Handle log message interpolation by the logger

    According to OpenStack Guideline[1], logged string message should be
    interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: I49952348c06e340c6cfc708028f2b06e02a16dfc
    Closes-Bug: #1661262

Changed in swift:
status: In Progress → Fix Released
Changed in horizon:
assignee: nobody → Gábor Antal (gabor.antal)

Fix proposed to branch: master
Review: https://review.openstack.org/428686

Changed in horizon:
status: New → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/430249

Changed in python-neutronclient:
assignee: nobody → Gábor Antal (gabor.antal)
status: New → In Progress
Changed in python-ceilometerclient:
assignee: nobody → Gábor Antal (gabor.antal)

Fix proposed to branch: master
Review: https://review.openstack.org/430253

Changed in python-ceilometerclient:
status: New → In Progress
Changed in python-ironicclient:
assignee: nobody → Gábor Antal (gabor.antal)

Fix proposed to branch: master
Review: https://review.openstack.org/430273

Changed in python-ironicclient:
status: New → In Progress
Changed in python-heatclient:
assignee: nobody → Gábor Antal (gabor.antal)
gordon chung (chungg) wrote :

please don't create generic bugs against multiple projects. launchpad doesn't handle this well and it also spams a lot of projects with unrelated updates. thanks :)

no longer affects: python-ceilometerclient
Hanxi Liu (hanxi-liu) wrote :

https://bugs.launchpad.net/nova/+bug/1596829
check if the same exists before proposing

Fix proposed to branch: master
Review: https://review.openstack.org/430282

Changed in python-heatclient:
status: New → In Progress

Okay, thanks for the information and sorry for the inconvience.

2017.02.07. 15:44 keltezéssel, gordon chung írta:
> please don't create generic bugs against multiple projects. launchpad
> doesn't handle this well and it also spams a lot of projects with
> unrelated updates. thanks :)
>
> ** No longer affects: python-ceilometerclient
>

Reviewed: https://review.openstack.org/430273
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=2f7e6652992268e5ff0a869e0032271a4c3f92fe
Submitter: Jenkins
Branch: master

commit 2f7e6652992268e5ff0a869e0032271a4c3f92fe
Author: Gábor Antal <email address hidden>
Date: Tue Feb 7 15:29:28 2017 +0100

    Handle log message interpolation by the logger

    According to OpenStack Guideline[1], logged string message should be
    interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: Ib15b59d1afceff8cc21605bc0f1afee33795923e
    Closes-Bug: #1661262

Changed in python-ironicclient:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/430282
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=28d8082f9ba50b95c699ab9a2473cd3421dc8048
Submitter: Jenkins
Branch: master

commit 28d8082f9ba50b95c699ab9a2473cd3421dc8048
Author: Gábor Antal <email address hidden>
Date: Tue Feb 7 15:48:37 2017 +0100

    Handle log message interpolation by the logger

    According to OpenStack Guideline[1], logged string message should be
    interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: Icbf550eecc0108e928aeb9e39dd28dfe482abe4b
    Closes-Bug: #1661262

Changed in python-heatclient:
status: In Progress → Fix Released

This issue was fixed in the openstack/swift 2.13.0 release.

Changed in python-neutronclient:
assignee: Gábor Antal (gabor.antal) → Akihiro Motoki (amotoki)
Changed in horizon:
assignee: Gábor Antal (gabor.antal) → Akihiro Motoki (amotoki)

This issue was fixed in the openstack/python-ironicclient 1.12.0 release.

This issue was fixed in the openstack/python-heatclient 1.9.0 release.

Reviewed: https://review.openstack.org/430249
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=6df0b27ee4fd9d6b23c503427c18f20441bd7c73
Submitter: Jenkins
Branch: master

commit 6df0b27ee4fd9d6b23c503427c18f20441bd7c73
Author: Gábor Antal <email address hidden>
Date: Tue Feb 7 14:22:32 2017 +0100

    Handle log message interpolation by the logger

    According to OpenStack Guideline[1], logged string message
    should be interpolated by the logger.

    [1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

    Change-Id: I5146c62cfd7e05270c5bf8ebc3ebab3908f1f1ca
    Closes-Bug: #1661262
    Co-Authored-By: Akihiro Motoki <email address hidden>

Changed in python-neutronclient:
status: In Progress → Fix Released

This issue was fixed in the openstack/python-neutronclient 6.3.0 release.

This issue was fixed in the openstack/python-ceilometerclient 2.9.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers