probe test can run even if resetswift failed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Object Storage (swift) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Swift has a bunch of test suites called "probe" to assert the actual statements in the running cluster. In the test suites, we need to cleanup the existing environment to create for each test specific situation (e.g. split brain) and we uses "resetswift" script for that.
That script is called another process via Popen module but the exit status is never checked before tests. When I running a probe test via "sudo nosetests test/probe", a tons of test were failed. Each test reported some assertion errors but but the actual failed reason is just "command: resetswift is not found" because the root doesn't have the path to the resetswift (/vagrant/
I wish I was able tosave our time from finding out the reason if we checked the exit code from resetswift before running probe tests,
Changed in swift: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
tags: | added: low-hanging-fruit |
The fix is proposed at https:/ /review. openstack. org/#/c/ 355687/, already.
Ah, I forgot to set closes-bug tag in the commit message. sorry.