common.utils.readconf SystemExit is noisy
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Object Storage (swift) |
Fix Released
|
Wishlist
|
Christian Hugo |
Bug Description
Anytime you want to use swift.common.
There's a couple of places in tree that do this, e.g.
That's.... fine.... i guess - but the real problem is the message that gets spewed to STDOUT:
May 4 17:11:17 precisenode0 object-auditor: STDOUT: Unable to find object-replicator config section in /etc/swift/
^ happens every pass when a new AuditorWorker is created/forked.
1) refactor readconf to raise a different error if the section isn't defined (probably ValueError?) - include the helpful text *in* the Exception
2) find all the call-sites of readconf that want to exit - and catch the ValueError and translate the message to SystemExit
3) find all the call-sites of readconf that *don't* want to exit - and catch the ValueError and observe no messages are sent to stdout/logged
optional step 4 is to worry about all there that was handling readconf's SystemExit that will have to be updated to handle ValueError...
Changed in swift: | |
assignee: | nobody → Annapoornima Koppad (annakoppad) |
Changed in swift: | |
assignee: | Annapoornima Koppad (annakoppad) → nobody |
Changed in swift: | |
assignee: | nobody → Christian Hugo (christianhugo) |
Fix proposed to branch: master /review. openstack. org/393388
Review: https:/