DiskFileDeleted is not a child of DiskFIleNotExist

Bug #1550840 reported by Kota Tsuyuzaki on 2016-02-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Wishlist
Unassigned

Bug Description

While fixing a bug [1], we found DiskfileDeleted inherits DiskFileNotExist.

However, (IMO), they could have different semaintics like as:

- DiskFileDeleted -> .ts file found but it's deleted
- DiskFileNotExist -> nothing is there in the dir (both of .data, .ts)

And the bug doesn't seems to occur, if we could ensure the difference as in the code.

However, once I was trying to change DiskFileDeleted to inherit just DiskFileError, a bunch of unit tests failed :/
So we need to look at this carefully but hopefully, It would be worthful in order to prevent similar bug in the future work.

https://review.openstack.org/#/c/281636/

Changed in swift:
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers