"swift-ring-builder set_info" command doesn't recognize 0 as a search value when "--id" is used as a key
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Object Storage (swift) |
Fix Released
|
Low
|
Unassigned |
Bug Description
Given the following ring builder:
=======
$ swift-ring-builder account.builder
account.builder, build version 16
131072 partitions, 3.000000 replicas, 1 regions, 1 zones, 3 devices, 0.00 balance, 0.00 dispersion
The minimum number of hours before a partition can be reassigned is 1
The overload factor is 0.00% (0.000000)
Devices: id region zone ip address port replication ip replication port name weight partitions balance meta
0 1 1 172.16.0.11 6002 172.16.0.11 6002 SSD1 100.00 131072 0.00
1 1 1 10.131.0.12 6002 10.131.0.12 6002 SSD2 100.00 131072 0.00
3 1 1 10.131.0.13 6002 10.131.0.13 6002 SSD3 100.00 131072 0.00
=======
I should be able to change IPs by using the ID as a key. This works when the ID is > 0. But fails for ID = 0:
=======
$ swift-ring-builder account.builder set_info --change-ip 10.131.0.11 --change-
Invalid <search-value>: '--id'
=======
Expected output should be similar to what I see when ID is > 0:
=======
$ swift-ring-builder account.builder set_info --change-ip 10.131.0.12 --change-
Device d1r1z1-
=======
This is with 2.5.0.
As an aside, the "--id" option/key seems undocumented in the help output of swift-ring-builder.
Changed in swift: | |
importance: | Undecided → Low |
status: | New → Confirmed |
tags: | added: low-hanging-fruit |
Changed in swift: | |
assignee: | nobody → Steve Wilkerson (sw5822) |
Changed in swift: | |
status: | Confirmed → In Progress |
Changed in swift: | |
assignee: | Steve Wilkerson (sw5822) → nobody |
Changed in swift: | |
status: | In Progress → Confirmed |
status: | Confirmed → In Progress |
assignee: | nobody → dangming (743759846-7) |
Changed in swift: | |
assignee: | dangming (743759846-7) → nobody |
Changed in swift: | |
status: | Fix Committed → Fix Released |
Fix proposed to branch: master /review. openstack. org/267308
Review: https:/