X-Timestamp missing from object PUT/COPY response headers

[Robert Francis]

Swift version 2.5.1.dev6
The Swift API, http://developer.openstack.org/api-ref-objectstorage-v1.html , indicates that object PUT/COPY should include X-Timestamp in the response headers, but a simple test indicates that X-Timestamp is missing.

[clayg (clay-gerrard)]

That was never in the response, not sure why it got documented that way.

Although I seem to recall last time I noticed it that it wasn't going to be anything crazy to add it.

I think the X-Timestamp is missing from most other unsafe operations on the other storage servers too (e.g. container POST).

[Robert Francis (robefran)]

Perhaps the best way to fix this is to update the Swift API under openstack-api-site to match the implemented behaviour.
I would raise the importance to Medium, I always get nervous when behaviour does not match the API. Makes me suspicious of the entire API. We should also add some tests to catch when behaviour does not match the published API.

I was going to use the X-Timestamp in the COPY response as part of tiering middleware.
I was going to use this X-Timestamp to force the timestamp of the symlink created after the copy to the cold-tier.
Clay, you discussed this timestamp manipulation in the tiering spec as a way to close a window of vulnerability between the COPY and the symlink creation.

I don't absolutely need the X-Timestamp from the COPY response, but it would be nice.
As an alternative, I can have the tiering middleware generate a timestamp, and force both the copied object and the symlink to
both use this middleware-generated timestamp.

[Jason Gu (jasongu)]

After going through each of the response headers documented under Swift API, I found additional missing X-Timestamps responses from the following APIs:

- Account:
                    POST

- Container:
                    POST PUT DELETE

- Object:
                   COPY POST PUT

[Robert Francis (robefran)]

Mustafa, do you plan to fix this in Swift, or in the docs (openstack-api-site) ?

[Mustafa Çelik (celikmustafa89)]

in swift

[Jason Gu (jasongu)]

Hi Mustafa, just a heads up but I have a functional test for the APIs, which I will upload to the community soon.

[Mustafa Çelik (celikmustafa89)]

also object delete does not have timestamp either

- Object:
                 DELETE

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/268163

[Mustafa Çelik (celikmustafa89)]

I sent my code to review. Can you review it?

Also I'am working on openstack-api-site for this bug. I'm gone sent it soon for review.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/269810

[Mustafa Çelik (celikmustafa89)]

Can you review the commit https://review.openstack.org/#/c/268163/