Individual files not in access log for bulk upload

Bug #1486193 reported by Samuel Merritt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Fix Released
Medium
Unassigned

Bug Description

If you upload 100 files via separate PUT requests, you get 100 lines in the proxy access logs. If you upload 100 files in a tarball and use bulk-upload to expand that to 100 separate objects in Swift, you get 1 line in the access log. I'd expect 101: one for the bulk-upload request, and 100 for the individual files.

Revision history for this message
Tim Burke (1-tim-z) wrote :

This wasn't fixed in https://github.com/openstack/swift/commit/a622349 ? Huh. I guess not...

And we explicitly say that we *do* expect subrequests to be logged: https://github.com/openstack/swift/blob/2.15.1/swift/common/middleware/bulk.py#L141-L146

Maybe just a matter of clearing/resetting environ['swift.proxy_access_log_made'] around https://github.com/openstack/swift/blob/2.15.1/swift/common/middleware/bulk.py#L529 ?

Changed in swift:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.openstack.org/502505
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=6f00d42f56d38e6267b819fdf06b7264feb50683
Submitter: Zuul
Branch: master

commit 6f00d42f56d38e6267b819fdf06b7264feb50683
Author: Tim Burke <email address hidden>
Date: Mon Sep 11 16:29:04 2017 +0000

    bulk: Use make_subrequest to make subrequests

    This ensures we log subrequests.

    Change-Id: I6b39d462a8c149f6d55db465f992f01eae465d57
    Closes-Bug: 1486193

Changed in swift:
status: Confirmed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/swift 2.20.0

This issue was fixed in the openstack/swift 2.20.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on swift (master)

Change abandoned by Tim Burke (<email address hidden>) on branch: master
Review: https://review.opendev.org/700652
Reason: Abandoned in favor of https://review.opendev.org/#/c/701736/ -- test improvements have been squashed in there.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.