Disk usage options are not applied when using --all with swift-recon

Bug #1344178 reported by David Moreau Simard
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Fix Released
David Moreau Simard

Bug Description

It is currently possible to have swift-recon report on disk usage by two means:
swift-recon -d OR
swift-recon --all (which includes -d)

Disk usage provides two options:
--human-readable to provide usage in MB/GB/TB++ rather than bytes
--top <integer> to list devices with the most usage

These options are currently usable when using -d but not --all.
This is because the options are not passed to disk_usage when using all:

Versus when using -d:

Changed in swift:
assignee: nobody → David Moreau Simard (dmsimard)
status: New → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/108109

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.openstack.org/108109
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=e1fb64a7a6c675d909fe76757ae6671e51de9a51
Submitter: Jenkins
Branch: master

commit e1fb64a7a6c675d909fe76757ae6671e51de9a51
Author: David Moreau Simard <email address hidden>
Date: Fri Jul 18 13:25:58 2014 -0400

    Pass disk usage options when using --all

    This commit allows the arguments --human-readable and --top to be
    used with --all to customize the output of the disk usage portion.

    There are no unit tests attached to this commit, I have created and
    referenced bug #1344200 which shows there is a larger bug to address
    to create several missing tests.

    Change-Id: I46b8359533989efc3067971acaafec1d0cbc2b9f
    Closes-Bug: #1344178
    Related-Bug: #1344200

Changed in swift:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (feature/ec)

Fix proposed to branch: feature/ec
Review: https://review.openstack.org/111505

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on swift (feature/ec)

Change abandoned by paul luse (<email address hidden>) on branch: feature/ec
Review: https://review.openstack.org/111505
Reason: accident

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (feature/ec)

Fix proposed to branch: feature/ec
Review: https://review.openstack.org/111866

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (feature/ec)
Download full text (15.2 KiB)

Reviewed: https://review.openstack.org/111866
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=9ace546b81b7efe606314e24fdb951ffe8e9a253
Submitter: Jenkins
Branch: feature/ec

commit e2255fc1f4d08993f41d3ff2eacc62a3c5f66ecd
Author: David Goetz <email address hidden>
Date: Thu Jul 31 10:19:10 2014 -0700

    fix expirer bug with unicode container listings

    If the container names in the expirer's account are returned as
    unicode strings (as is the case with some json libraries), the
    expirer compared eg u'1' == '1', which is problematic. This patch
    ensures that the unicode is coerced to ascii so the comparison
    is correct.

    Change-Id: I72b322e7513f7da32e8dc75c6bf0e7e016948c88

commit 4286f36a60446e322f23a329416be3ed67db1149
Author: anc <email address hidden>
Date: Mon Mar 10 11:46:58 2014 +0000

    Enable object system metadata on PUTs

    This patch takes a first step towards support
    for object system metadata by enabling headers
    in the x-object-sysmeta- namespace to be
    persisted when objects are PUT. This should be
    useful for other pending patches such as on
    demand migration and server side encryption
    (https://review.openstack.org/#/c/64430/ and

    The x-object-sysmeta- namespace is already
    reserved/protected by the gatekeeper and
    passed through the proxy. This patch modifies
    the object server to persist these headers
    alongside user metadata when an object is

    This patch will preserve existing object
    system metadata and ignore any new system
    metadata when handling object POSTs,
    including POST-as-copy operations. Support
    for modification of object system metadata
    with a POST request requires further work
    as discussed in the blueprint.

    This patch will preserve existing object
    system metadata and update it with new
    system metadata when copying an object.

    A new probe test is added which makes use of
    the BrainSplitter class that has been moved
    from test_container_merge_policy_index.py to
    a new module brain.py.

    blueprint object-system-metadata

    Change-Id: If716bc15730b7322266ebff4ab8dd31e78e4b962

commit 8ad37b2217c30b756bb79ead84be7c04f628ed36
Author: Christian Schwede <email address hidden>
Date: Fri Aug 1 13:55:21 2014 +0000

    Fix swift-dispersion-populate bug when using SimpleClient class

    Commit 7fcbbebb changed the internal client a little bit and removed the
    class variable self.attempts in SimpleClient. This is currently still
    needed in swift-dispersion-populate to track the number of retries, thus
    re-adding it again.

    Closes-Bug: 1351323
    Change-Id: I98ba6441607158b34708b2dbb2d1a63788681d63

commit 5a84b1cde102dac4ae5a40a20a364ada1dc547e9
Author: Samuel Merritt <email address hidden>
Date: Thu Jul 31 12:18:47 2014 -0700

    Put proxy-logging in object expirer's sample config

    It's generally better to have logs for something than to not have
    logs. This way, the object expirer (if using the sample config as a
    starting point) will log wh...

Thierry Carrez (ttx)
Changed in swift:
milestone: none → 2.1.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers