Bug #1316716 “test.unit.proxy.test_server:TestObjectController.t...” : Bugs : OpenStack Object Storage (swift)

Revision history for this message

clayg (clay-gerrard) wrote on 2014-05-06:

#1

timeout faster Edit (673 bytes, text/plain)

Revision history for this message

clayg (clay-gerrard) wrote on 2014-05-06:

#2

example of failure:

http://logs.openstack.org/51/88151/5/check/gate-swift-python27/4e2d94b/nose_results.html

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-10: Fix merged to swift (master)

#3

Reviewed: https://review.openstack.org/104889
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=9150fb383e27c7e4f0bf5550e45a508b4882ccd1
Submitter: Jenkins
Branch: master

commit 9150fb383e27c7e4f0bf5550e45a508b4882ccd1
Author: Paul Luse <email address hidden>
Date: Fri Jul 4 05:17:03 2014 -0700

Adjust timeout value in test_client_timeout

    Per information filed in bug (and related bugs referenced in the
    report) it appears that in TestObjectController.test_client_timeout
    having a matching timeout value for both self.app.client_timeout
    and SlowBody() appears to work however, as expected, a smaller
    value in self.app.client_timeout also works where a larger
    value fails. With that short test combined with speculation and
    related fixes, seems reasonable to merge what is suggested in
    the bug report, drop the self.app.client_timeout to 0.05

Fixes Bug #1316716

Change-Id: Ib4c6d3bb275f6c50c62505c90656efa7ee566bc0

Changed in swift:
status:	New → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-14: Fix proposed to swift (feature/ec)

#4

Fix proposed to branch: feature/ec
Review: https://review.openstack.org/106815

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-07-21: Fix merged to swift (feature/ec)

#5

Download full text (6.5 KiB)

Reviewed: https://review.openstack.org/106815
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=c4cbfb307bf88cd200ef9b2d5e780d79b95f746a
Submitter: Jenkins
Branch: feature/ec

commit 0753dd39231270150d61e051175dcdbd106836b5
Author: Peter Portante <email address hidden>
Date: Mon Jun 2 13:36:21 2014 -0400

Handle func tests of swift cluster that hide /info

    If a swift cluster configures the proxy server to not accept
    /info requests, just do the best we can, skipping tests as
    necessary.

To that end, if cors mode is not known we also skip the test.

Change-Id: I34f296c8717e0baf24ae552a7e38f9354ee91974

commit 7ea30df9cdd416bdc41762f1bc31c3971d55ae34
Author: paul luse <email address hidden>
Date: Thu Jul 10 06:21:56 2014 -0700

Update docs to highlight that the auditor chunk size can be set

    May not be obvious, but existing code will let you change the
    disk_chunk_size just for the auditor so this just points that
    out in the docs. In one short test I ran with a 4 node cluster
    with 18GB of 4MB objects on it, changint he auditor chunk size
    from the default of 64K to 1MB creased the auditor CPU time from
    10% to 4%.

    Also added test code to make sure this overridden value is
    actually used and checked other auditWorker conf values as
    well.

Change-Id: Ia12e1c6127877dc2124b60cd963cd0b6d5f3d6ef

commit 7ab2afe5bd5a30615cae83efc401b581b0c2dc5a
Author: John Dickinson <email address hidden>
Date: Mon Jul 7 17:11:38 2014 -0700

added process pid to the end of storage node log lines

Change-Id: I1c2709d85575fc7d4868fafd9ee757fd01868436

commit 0582db728fa5931cae143014a9b3ac1205a23855
Author: gholt <email address hidden>
Date: Tue Jul 8 15:14:25 2014 +0000

This setting should've been set to False back ...

...with commit 9eb797b09916574c2a4e0f5f9ea61fe120879075

    With this setting to True in the code, any tools anyone writes will
    automatically start preallocating, which is almost always bad these days
    with SSDs. So, if you write a tool that just scan dbs for stats, it'll
    commit any pending info triggering preallocation and bam, your SSDs
    start to fill up. :/

    Anyway, back when I wrote 9eb797b09916574c2a4e0f5f9ea61fe120879075 it
    was my intention to have this off by default, everywhere; I changed all
    the settings points but I failed to change the dang constant itself.
    This corrects that.

Change-Id: Iada0a3f1ecfabda4a96f574903d8e2eed1f69064

commit 9150fb383e27c7e4f0bf5550e45a508b4882ccd1
Author: Paul Luse <email address hidden>
Date: Fri Jul 4 05:17:03 2014 -0700

Adjust timeout value in test_client_timeout

    Per information filed in bug (and related bugs referenced in the
    report) it appears that in TestObjectController.test_client_timeout
    having a matching timeout value for both self.app.client_timeout
    and SlowBody() appears to work however, as expected, a smaller
    value in self.app.client_timeout also works where a larger
    value fails. With that short test combined with speculation and
    related fixes, seems reasonable to merge what...

Reviewed:  https://review.openstack.org/106815
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=c4cbfb307bf88cd200ef9b2d5e780d79b95f746a
Submitter: Jenkins
Branch:    feature/ec

commit 0753dd39231270150d61e051175dcdbd106836b5
Author: Peter Portante <peter.portante@redhat.com>
Date:   Mon Jun 2 13:36:21 2014 -0400

Handle func tests of swift cluster that hide /info
    
    If a swift cluster configures the proxy server to not accept
    /info requests, just do the best we can, skipping tests as
    necessary.
    
    To that end, if cors mode is not known we also skip the test.
    
    Change-Id: I34f296c8717e0baf24ae552a7e38f9354ee91974

commit 7ea30df9cdd416bdc41762f1bc31c3971d55ae34
Author: paul luse <paul.e.luse@intel.com>
Date:   Thu Jul 10 06:21:56 2014 -0700

Update docs to highlight that the auditor chunk size can be set
    
    May not be obvious, but existing code will let you change the
    disk_chunk_size just for the auditor so this just points that
    out in the docs.  In one short test I ran with a 4 node cluster
    with 18GB of 4MB objects on it, changint he auditor chunk size
    from the default of 64K to 1MB creased the auditor CPU time from
    10% to 4%.
    
    Also added test code to make sure this overridden value is
    actually used and checked other auditWorker conf values as
    well.
    
    Change-Id: Ia12e1c6127877dc2124b60cd963cd0b6d5f3d6ef

commit 7ab2afe5bd5a30615cae83efc401b581b0c2dc5a
Author: John Dickinson <me@not.mn>
Date:   Mon Jul 7 17:11:38 2014 -0700

added process pid to the end of storage node log lines
    
    Change-Id: I1c2709d85575fc7d4868fafd9ee757fd01868436

commit 0582db728fa5931cae143014a9b3ac1205a23855
Author: gholt <z-launchpad@brim.net>
Date:   Tue Jul 8 15:14:25 2014 +0000

This setting should've been set to False back ...
    
    ...with commit 9eb797b09916574c2a4e0f5f9ea61fe120879075
    
    With this setting to True in the code, any tools anyone writes will
    automatically start preallocating, which is almost always bad these days
    with SSDs. So, if you write a tool that just scan dbs for stats, it'll
    commit any pending info triggering preallocation and bam, your SSDs
    start to fill up. :/
    
    Anyway, back when I wrote 9eb797b09916574c2a4e0f5f9ea61fe120879075 it
    was my intention to have this off by default, everywhere; I changed all
    the settings points but I failed to change the dang constant itself.
    This corrects that.
    
    Change-Id: Iada0a3f1ecfabda4a96f574903d8e2eed1f69064

commit 9150fb383e27c7e4f0bf5550e45a508b4882ccd1
Author: Paul Luse <paul.e.luse@intel.com>
Date:   Fri Jul 4 05:17:03 2014 -0700

Adjust timeout value in test_client_timeout
    
    Per information filed in bug (and related bugs referenced in the
    report) it appears that in TestObjectController.test_client_timeout
    having a matching timeout value for both self.app.client_timeout
    and SlowBody() appears to work however, as expected, a smaller
    value in self.app.client_timeout also works where a larger
    value fails.  With that short test combined with speculation and
    related fixes, seems reasonable to merge what is suggested in
    the bug report, drop the self.app.client_timeout to 0.05
    
    Fixes Bug #1316716
    
    Change-Id: Ib4c6d3bb275f6c50c62505c90656efa7ee566bc0

commit bfa9139649c0ac7f75e8c9503cb04d06f7bae0b9
Author: Paul Luse <paul.e.luse@intel.com>
Date:   Wed Jul 2 14:39:42 2014 -0700

Fix potential missing key error in container_info
    
    If upgrading from a non-storage policy enabled version of
    swift to a storage policy enabled version its possible that
    memcached will have an info structure that does not contain
    the 'storage_policy" key resulting in an unhandled exception
    during the lookup.  The fix is to simply make sure we never
    return the dict without a storage_policy key defined; if it
    doesn't exist its safe to make it '0' as this means you're
    in the update scenario and there's xno other possibility.
    
    Change-Id: If8c88f67ba7a3180ad06b586372fe35c65807aac

commit 7dbf8324569d45897f2b4f05cd97299366eff23d
Author: Clay Gerrard <clay.gerrard@gmail.com>
Date:   Mon Jun 30 21:49:49 2014 -0700

Fix pop_queue for move object twice
    
    With the two vector timestamp change some resolution was lost in the queue
    entries that could lead to the reconciler being unable to successfully remove
    a processed item from the queue in pop_queue.  To ensure the queue entries
    with a significant offset can be successfully removed while still handling
    the re-enqueued object case issue the DELETE with the timestamp slightly later
    than the maximum of the queue entries last modified time (q_record) and
    misplaced objects timestamp (q_ts).
    
    Change-Id: I87b1e4b4256af3f71defb58c8137c303d1ae63be

commit fb5a0f21ddfde12f503c4a7048d8b8ca1c2724ef
Author: Clay Gerrard <clay.gerrard@gmail.com>
Date:   Wed Jun 25 11:38:54 2014 -0700

Fix KeyError on Storage Policy Container Sync
    
    In the proxy, container_info can return a 'storage_policy' of None.  When
    you set a header value on a swob.Request to None that effectively just
    delete's the key.  One path through the proxy during container sync was
    counting on the the 'X-Backend-Storage-Policy-Index' being set which isn't
    the case if the cached container_info if for a pre-policies container.
    
    Also clean up some test cruft, tighten up the interface on FakeConn, and add
    some object controller tests to exercise more interesting failure and handoff
    code paths.
    
    Change-Id: I643e08c208efdc5a39e840d9e96710ddad54236b

commit 5d7c8ca928895a5c77ad7d82f873db07a1a236e6
Author: liuqing <jing.liuqing@99cloud.net>
Date:   Tue Jul 1 15:57:42 2014 +0800

Fix the section name in CONTRIBUTING.rst
    
    The name of the section "If you're developer, start here"
    has changed in the wiki, now is "If you're a developer".
    This commit updates it to correctly refer to the
    proper section.
    
    Change-Id: I724107362c7eaf895133ab0a902a575081c025be

commit 5580b09635b5e9128038738444301d5c232ed788
Author: Clay Gerrard <clay.gerrard@gmail.com>
Date:   Fri May 2 21:11:49 2014 -0700

Add filename*= support to tempurl Content-Disposition
    
    When working with unicode or unsafe characters most browsers can do better
    with a fully quoted filename*=, and will prefer it to filename=.  Old style
    filename= left in for backwards compat
    
    Change-Id: Ic54b0c376139bc8688d9124930689285a3b384fb

Thierry Carrez (ttx) on 2014-08-25

Changed in swift:
milestone:	none → 2.1.0
status:	Fix Committed → Fix Released

OpenStack Object Storage (swift)

test.unit.proxy.test_server:TestObjectController.test_client_timeout fails in the gate

Bug Description

Other bug subscribers

Patches

Remote bug watches