swift-recon-cron lock dir not removed on failure
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Object Storage (swift) |
In Progress
|
Undecided
|
Christopher H. Laco |
Bug Description
Under certain circumstances, if get_async_count or dump_cron_cache calls fail, the lock_dir is not cleaned up.
You can simulate this by running this cron on a machine without /srv/node, which will yield the following exception:
Traceback (most recent call last):
File "/usr/bin/
main()
File "/usr/bin/
dump_
UnboundLocalError: local variable 'asyncs' referenced before assignment
All subsequent executions of swift-recon-cron will fail with the following error until the lock_dir is removed:
[Errno 17] File exists: '/var/lock/
2013 Nov 15 16:44:02 storage-server-1 [Errno 17] File exists: '/var/lock/
Error handling should probably be a bit more robust to ensure the lock_dir always gets removed. Patch forthcoming.
Changed in swift: | |
assignee: | nobody → Christopher H. Laco (claco) |
status: | New → In Progress |
Fix proposed to branch: master /review. openstack. org/56670
Review: https:/