recheck_account_existence of 0 causes all container and object requests to fail

[clayg]

if you set recheck_account_existance to 0 all of your container and object requests fail the account existence check - it's pretty whack.

in proxy.controllers.base._set_info_cache there's an early return case when cache_time 0 but it turns out that env[env_key] = info bit at the bottom is really important to get_info.

I think account_existence_check of zero probably means no memcache, but the request should still *work*?

[Samuel Merritt (torgomatic)]

Looks like that should be a test for "cache_time is not None", not just a truthiness check.

I'd expect it to populate the per-request check and just not send anything to memcache.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/310216
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=1883c1ec23b6dfa7a266ed36f905fbd0501cc87c
Submitter: Jenkins
Branch: master

commit 1883c1ec23b6dfa7a266ed36f905fbd0501cc87c
Author: Tim Burke <email address hidden>
Date: Tue Apr 26 09:15:29 2016 -0500

    Make get_info requests useful with recheck_*_existence == 0

    Before, when recheck_account_existence or recheck_container_existence
    was set to zero, get_info requests for accounts or containers wouldn't
    populate the env cache for the current request, so it wouldn't return
    the data *it just got*.

    Now, we'll still populate the env cache and memcache, as a cache time of
    zero means "keep it indefinitely". See the memcache docs at
    https://github.com/memcached/memcached/blob/1.4.25/doc/protocol.txt#L163

    Change-Id: Ia648263073bc88e35216cafb76821b7ce02c1d03
    Closes-Bug: 1224734

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/swift 2.10.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: feature/hummingbird
Review: https://review.openstack.org/400985

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/400985
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=0c3f8f87104af8717115c5badffd243dbaa1c430
Submitter: Jenkins
Branch: feature/hummingbird

commit 2d25fe6ad3573b2a06b6b3e5e66493d7b0c55693
Author: Tim Burke <email address hidden>
Date: Mon Jul 25 15:06:23 2016 -0700

    Reduce backend requests for SLO If-Match / HEAD requests

    ... by storing SLO Etag and size in sysmeta.

    Previously, we had to GET the manifest for every HEAD or conditional
    request to an SLO. Worse, since SLO PUTs require that we HEAD every
    segment, we'd GET all included sub-SLO manifests. This was necessary so
    we could recompute the large object's Etag and content-length.

    Since we already know both of those during PUT, we'll now store it in
    object sysmeta. This allows us to:

     * satisfy HEAD requests based purely off of the manifest's HEAD
       response, and
     * perform the If-(None-)Match comparison on the object server, without
       any additional subrequests.

    Note that the large object content-length can't just be parsed from
    content-type -- with fast-POST enabled, the content-type coming out of
    the object-server won't necessarily include swift_bytes.

    Also note that we must still fall back to GETting the manifest if the
    sysmeta headers were not found. Otherwise, we'd break existing large
    objects.

    Change-Id: Ia6ad32354105515560b005cea750aa64a88c96f9

commit ae7dddd801e28217d7dc46bd45cd6b621f29340c
Author: Ondřej Nový <email address hidden>
Date: Mon Nov 21 22:13:11 2016 +0100

    Added comment for "user" option in drive-audit config

    Change-Id: I24362826bee85ac3304e9b63504c9465da673014

commit c3e1d847f4b9d6cc6212aae4dc1b1e6dff45fb40
Author: Thiago da Silva <email address hidden>
Date: Thu Nov 17 17:17:00 2016 -0500

    breaking down tests.py into smaller pieces

    tests.py is currently at ~5500 lines of code, it's
    time to break it down into smaller files.

    I started with an easy middleware set of tests
    (i.e., versioned writes, ~600 lines of code ) so I can get
    some feedback. There are more complicated tests that cover
    multiple middlewares for example, it is not so clear where
    those should go.

    Change-Id: I2aa6c18ee5b68d0aae73cc6add8cac6fbf7f33da
    Signed-off-by: Thiago da Silva <email address hidden>

commit 5d7a3a4172f0f11ab870252eec784cf24b247dea
Author: Ondřej Nový <email address hidden>
Date: Sat Nov 19 23:24:30 2016 +0100

    Removed "in-process-" from func env tox name

    This shorten shebang in infra, because we are hitting 128 bytes limit.

    Change-Id: I02477d81b836df71780942189d37d616944c4dce

commit 9ea340256996a03c8c744201297b47a0e91fe65b
Author: Kota Tsuyuzaki <email address hidden>
Date: Fri Nov 18 01:50:11 2016 -0800

    Don't overwrite built-in 'id'

    This is a follow up for https://review.openstack.org/#/c/399237

    'id' is assigned as a builtin function so that we should not use 'id'
    for the local variable name.

    Change-Id: Ic27460d49e68f6cd50bda1d5b3810e01ccb07a37

commit bf...

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/swift 2.10.0 release.