Use testtools for base test class
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ceilometer |
Fix Released
|
Undecided
|
Angus Salkeld | ||
Cinder |
Undecided
|
Michael Kerrin | |||
Glance |
Undecided
|
Unassigned | |||
OpenStack DBaaS (Trove) |
In Progress
|
Low
|
Nikhil Manchanda | ||
OpenStack Dashboard (Horizon) |
Wishlist
|
Wu Wenxiang | |||
OpenStack Identity (keystone) |
Wishlist
|
Viktor Serhieiev | |||
OpenStack Object Storage (swift) |
Wishlist
|
Kuo-tung Kao (jelly) | |||
Sahara |
Fix Released
|
Medium
|
Andrew Lazarev | ||
Zuul |
New
|
Undecided
|
Unassigned | ||
git-review |
Fix Committed
|
High
|
Dina Belova | ||
oslo-incubator |
Undecided
|
Unassigned | |||
python-ceilometerclient |
Undecided
|
Angus Salkeld | |||
python-heatclient |
Fix Released
|
Undecided
|
Unassigned | ||
tempest |
Undecided
|
Unassigned |
Bug Description
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
The testtools library has been chosen as the project-wide testing base
class. It works across 2.6 and 2.7 and is a library that aims to develop
new testing features before inclusion in the standard library. It
enforces a few elements of correctness, such as always upcalling
standard methods, as well as providing hooks for features such as detail
collection and fixtures with cleanup.
affects ceilometer
affects cinder
affects git-review
affects glance
affects horizon
affects keystone
affects openstack-ci
affects oslo
affects python-
affects python-heatclient
affects reddwarf
affects swift
affects tempest
affects zuul
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with undefined - http://
iEYEARECAAYFAlG
OrMAoK2LacTVUNh
=QEI2
-----END PGP SIGNATURE-----
Gabriel Hurley (gabriel-hurley) wrote : | #1 |
Changed in horizon: | |
importance: | Undecided → Wishlist |
milestone: | none → havana-1 |
status: | New → Triaged |
Angus Salkeld (asalkeld) wrote : | #2 |
(this has already been commited for python-
https:/
Changed in python-ceilometerclient: | |
assignee: | nobody → Angus Salkeld (asalkeld) |
status: | New → Fix Committed |
Angus Salkeld (asalkeld) wrote : | #3 |
Changed in ceilometer: | |
assignee: | nobody → Angus Salkeld (asalkeld) |
status: | New → Fix Committed |
Changed in horizon: | |
milestone: | havana-1 → havana-2 |
Fix proposed to branch: master
Review: https:/
Changed in cinder: | |
assignee: | nobody → Michael Kerrin (michael-kerrin-w) |
status: | New → In Progress |
Changed in ceilometer: | |
milestone: | none → havana-1 |
status: | Fix Committed → Fix Released |
Changed in openstack-ci: | |
assignee: | nobody → Monty Taylor (mordred) |
importance: | Undecided → Medium |
milestone: | none → havana |
status: | New → Triaged |
Attila Fazekas (afazekas) wrote : | #5 |
It is a base class since long.
With python2.6 when I use nosetests the skip exceptions from setUpClasses are considered as ERRORs instead of skip.
Changed in tempest: | |
status: | New → Fix Released |
Changed in keystone: | |
importance: | Undecided → Wishlist |
status: | New → Triaged |
Changed in horizon: | |
milestone: | havana-2 → havana-3 |
Angus Salkeld (asalkeld) wrote : | #6 |
Changed in python-heatclient: | |
status: | New → Fix Committed |
Changed in keystone: | |
assignee: | nobody → Victor Sergeyev (vsergeyev) |
Changed in keystone: | |
status: | Triaged → In Progress |
no longer affects: | openstack-ci |
Changed in git-review: | |
assignee: | nobody → Dina Belova (dbelova) |
importance: | Undecided → High |
status: | New → Fix Committed |
Ben Nemec (bnemec) wrote : | #7 |
As near as I can tell, this is already the case in all of the Oslo projects. Marking as fix committed instead of invalid since I'm not sure whether this was done before or after this bug was opened.
Changed in oslo: | |
status: | New → Fix Committed |
Changed in horizon: | |
milestone: | havana-3 → none |
Reviewed: https:/
Committed: http://
Submitter: Jenkins
Branch: master
commit 221851c8ac78362
Author: Victor Sergeyev <email address hidden>
Date: Mon Jul 29 09:42:50 2013 +0300
Use testtools as base test class.
Minor tests refactoring due to use testtools:
- added missed setUp() and tearDown() to call these functions in
base test case.
- removed some superfluous tearDown() calls.
- moved test_crud_
to separate class.
Fixes for python 2.6 enviroment:
- replaced `with self.assertRais
- added to safe_repr(), assertDictEqual() and assertRaisesReg
to TestCase() class in keystone/test.py
Fixes bug 1179009
Change-Id: Iea67ad10d02db8
Changed in keystone: | |
status: | In Progress → Fix Committed |
Changed in keystone: | |
milestone: | none → havana-3 |
status: | Fix Committed → Fix Released |
Changed in oslo: | |
milestone: | none → havana-3 |
status: | Fix Committed → Fix Released |
I will be out of the office starting 2013-09-05 and will not return until
2013-09-15.
I will be on my marriage leave from 9/5 to 9/15, for any urgent issue
please call me before 9/7.
For daily work, please ask my scrum master Zhu Zhu for help.
For glance issue, please ask glance SME Feilong Wang for help.
For defect report, there will be no report next week.
Changed in python-heatclient: | |
status: | Fix Committed → Fix Released |
Changed in oslo: | |
milestone: | havana-3 → 2013.2 |
Changed in ceilometer: | |
milestone: | havana-1 → 2013.2 |
Changed in keystone: | |
milestone: | havana-3 → 2013.2 |
Changed in trove: | |
importance: | Undecided → Low |
Changed in trove: | |
importance: | Low → Medium |
status: | New → Triaged |
Changed in trove: | |
assignee: | nobody → Denis M. (dmakogon) |
status: | Triaged → In Progress |
Steve Kowalik (stevenk) wrote : | #10 |
Glance uses testrepository as of commit d7f1221684ea3c9
Changed in glance: | |
status: | New → Fix Committed |
Changed in glance: | |
milestone: | none → icehouse-rc1 |
status: | Fix Committed → Fix Released |
Changed in glance: | |
milestone: | icehouse-rc1 → 2014.1 |
Changed in trove: | |
assignee: | Denis M. (dmakogon) → nobody |
status: | In Progress → New |
Changed in sahara: | |
importance: | Undecided → Medium |
milestone: | none → juno-1 |
status: | New → Triaged |
assignee: | nobody → Andrew Lazarev (alazarev) |
Changed in python-saharaclient: | |
importance: | Undecided → Medium |
milestone: | none → 0.7.1 |
status: | New → Triaged |
Changed in sahara: | |
status: | Triaged → In Progress |
Changed in python-saharaclient: | |
assignee: | nobody → Andrew Lazarev (alazarev) |
Andrew Lazarev (alazarev) wrote : | #11 |
python-saharaclient uses testtools from day one.
Changed in python-saharaclient: | |
assignee: | Andrew Lazarev (alazarev) → nobody |
no longer affects: | python-saharaclient |
Changed in sahara: | |
milestone: | juno-1 → juno-2 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 95e1c2f00bda95e
Author: Andrew Lazarev <email address hidden>
Date: Fri May 30 16:38:06 2014 -0700
Migrated unit tests to testtools
Main changes:
* testtools checks that base setUp is called
* assertRaises doesn't return context
* testtools inherits from unittest (not unittest2) and doesn't have
specific compare functions in py2.6
Notes:
* Integration tests will be tracked separately (bp: it-testtools)
* Migration to oslotest will be tracked separately (bp: oslotest)
* bug #1325108 is out of scope of this CR
Implements blueprint: ut-testtools
Closes-Bug: #1179009
Change-Id: I85f0ea1aa972ff
Changed in sahara: | |
status: | In Progress → Fix Committed |
Jeremy Stanley (fungi) wrote : | #13 |
Can't seem to set this to fix-released for git-review (even via SMTP API), so commenting here instead.
Changed in sahara: | |
status: | Fix Committed → Fix Released |
Changed in trove: | |
status: | New → Triaged |
Changed in sahara: | |
milestone: | juno-2 → 2014.2 |
Changed in trove: | |
importance: | Medium → Wishlist |
Changed in horizon: | |
assignee: | nobody → Ekaterina Chernova (efedorova) |
Changed in horizon: | |
assignee: | Ekaterina Chernova (efedorova) → Wu Wenxiang (wu-wenxiang) |
status: | Triaged → In Progress |
Fix proposed to branch: master
Review: https:/
Changed in trove: | |
assignee: | nobody → Wu Wenxiang (wu-wenxiang) |
status: | Triaged → In Progress |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 8e8c084847280f3
Author: Wu Wenxiang <wu.wenxiang@
Date: Wed Feb 4 03:58:25 2015 -0800
Replace unittest2 with testtools
Remove unittest2 from test-requiremen
Replace unittest2 with testtools in files:
* openstack_
* openstack_
* openstack_
Change-Id: Ic56b1096386548
Closes-Bug: #1179009
Changed in horizon: | |
status: | In Progress → Fix Committed |
Changed in horizon: | |
milestone: | none → kilo-3 |
status: | Fix Committed → Fix Released |
Changed in horizon: | |
milestone: | kilo-3 → 2015.1.0 |
Changed in swift: | |
assignee: | nobody → jelly (coding1314) |
status: | New → In Progress |
Change abandoned by Nikhil Manchanda (<email address hidden>) on branch: master
Review: https:/
Reason: Looks like this change is no longer needed or has been superseded. Abandoning to clean out the review queue. Feel free to restore if this is not the case, and this is still a change that is actively being worked upon. Thanks!
Changed in swift: | |
importance: | Undecided → Wishlist |
Changed in python-ceilometerclient: | |
status: | Fix Committed → Fix Released |
Change abandoned by John Dickinson (<email address hidden>) on branch: master
Review: https:/
Reason: Abanoning based on the lack of activity since the last negative review. If you want to continue working on this, please reopen this patch.
Changed in cinder: | |
status: | In Progress → Fix Released |
Fix proposed to branch: master
Review: https:/
Changed in trove: | |
assignee: | Wu Wenxiang (wu-wenxiang) → Nikhil Manchanda (slicknik) |
Changed in trove: | |
importance: | Wishlist → Low |
milestone: | none → newton-1 |
Change abandoned by Nikhil Manchanda (<email address hidden>) on branch: master
Review: https:/
Reason: Abandoning for now
I will be interested to see how integrating this into Django's test runner works out for Horizon. I'm not opposed to it, but suspect it may not be trivial.