Use testtools for base test class

[Monty Taylor]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The testtools library has been chosen as the project-wide testing base
class. It works across 2.6 and 2.7 and is a library that aims to develop
new testing features before inclusion in the standard library. It
enforces a few elements of correctness, such as always upcalling
standard methods, as well as providing hooks for features such as detail
collection and fixtures with cleanup.

 affects ceilometer
 affects cinder
 affects git-review
 affects glance
 affects horizon
 affects keystone
 affects openstack-ci
 affects oslo
 affects python-ceilometerclient
 affects python-heatclient
 affects reddwarf
 affects swift
 affects tempest
 affects zuul
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iEYEARECAAYFAlGObtcACgkQ2Jv7/VK1RgH0AgCg8uEx2Za2rXscfse508hhog7p
OrMAoK2LacTVUNhbe6R6AxO8XXXB1PWv
=QEI2
-----END PGP SIGNATURE-----

[Gabriel Hurley (gabriel-hurley)]

I will be interested to see how integrating this into Django's test runner works out for Horizon. I'm not opposed to it, but suspect it may not be trivial.

[Angus Salkeld (asalkeld)]

(this has already been commited for python-ceilometerclient)
https://github.com/openstack/python-ceilometerclient/commit/7091db40a9486ebdc8a19699826b171465e40384

[Angus Salkeld (asalkeld)]

https://github.com/openstack/ceilometer/commit/e9a30f61fe1f51a8758c4587e8822723fefc3c4e

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/30291

[Attila Fazekas (afazekas)]

It is a base class since long.

With python2.6 when I use nosetests the skip exceptions from setUpClasses are considered as ERRORs instead of skip.

[Angus Salkeld (asalkeld)]

https://github.com/openstack/python-heatclient/commit/2e6e49f7fa49c977fb9e406e1a49a99792e80775

[Ben Nemec (bnemec)]

As near as I can tell, this is already the case in all of the Oslo projects. Marking as fix committed instead of invalid since I'm not sure whether this was done before or after this bug was opened.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/39064
Committed: http://github.com/openstack/keystone/commit/221851c8ac78362418dc3e5c3f5659f78c012c35
Submitter: Jenkins
Branch: master

commit 221851c8ac78362418dc3e5c3f5659f78c012c35
Author: Victor Sergeyev <email address hidden>
Date: Mon Jul 29 09:42:50 2013 +0300

    Use testtools as base test class.

    Minor tests refactoring due to use testtools:
     - added missed setUp() and tearDown() to call these functions in
       base test case.
     - removed some superfluous tearDown() calls.
     - moved test_crud_inherited_role_grants_failed_if_disabled() method
       to separate class.

    Fixes for python 2.6 enviroment:
     - replaced `with self.assertRaises(Exception): foo()` to
       `self.assertRaises(Exception, foo)
     - added to safe_repr(), assertDictEqual() and assertRaisesRegexp() methods
       to TestCase() class in keystone/test.py

    Fixes bug 1179009

    Change-Id: Iea67ad10d02db82fc8ed79b1096ddb5233925bfd

[Yang Yu (yuyangbj)]

I will be out of the office starting 2013-09-05 and will not return until
2013-09-15.

I will be on my marriage leave from 9/5 to 9/15, for any urgent issue
please call me before 9/7.

For daily work, please ask my scrum master Zhu Zhu for help.
For glance issue, please ask glance SME Feilong Wang for help.
For defect report, there will be no report next week.

[Steve Kowalik (stevenk)]

Glance uses testrepository as of commit d7f1221684ea3c958f0a382764074adb5ee6cbcf.

[Andrew Lazarev (alazarev)]

python-saharaclient uses testtools from day one.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/96979
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=95e1c2f00bda95ed49f13879a83ca4fcbf054a1a
Submitter: Jenkins
Branch: master

commit 95e1c2f00bda95ed49f13879a83ca4fcbf054a1a
Author: Andrew Lazarev <email address hidden>
Date: Fri May 30 16:38:06 2014 -0700

    Migrated unit tests to testtools

    Main changes:
    * testtools checks that base setUp is called
    * assertRaises doesn't return context
    * testtools inherits from unittest (not unittest2) and doesn't have
      specific compare functions in py2.6

    Notes:
    * Integration tests will be tracked separately (bp: it-testtools)
    * Migration to oslotest will be tracked separately (bp: oslotest)
    * bug #1325108 is out of scope of this CR

    Implements blueprint: ut-testtools
    Closes-Bug: #1179009

    Change-Id: I85f0ea1aa972ff68ddd1817ec936a8c26312f041

[Jeremy Stanley (fungi)]

Can't seem to set this to fix-released for git-review (even via SMTP API), so commenting here instead.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/157366

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/152869
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8e8c084847280f3f8e975910b498ed9fbb3a69c8
Submitter: Jenkins
Branch: master

commit 8e8c084847280f3f8e975910b498ed9fbb3a69c8
Author: Wu Wenxiang <[e-mail]>
Date: Wed Feb 4 03:58:25 2015 -0800

    Replace unittest2 with testtools

    Remove unittest2 from test-requirements.txt
    Replace unittest2 with testtools in files:
    * openstack_dashboard/test/api_tests/keystone_rest_tests.py
    * openstack_dashboard/test/api_tests/rest_util_tests.py
    * openstack_dashboard/test/api_tests/nova_rest_tests.py

    Change-Id: Ic56b1096386548e8253e40cbd54ee5fc579cf413
    Closes-Bug: #1179009

[OpenStack Infra (hudson-openstack)]

Change abandoned by Nikhil Manchanda (<email address hidden>) on branch: master
Review: https://review.openstack.org/157366
Reason: Looks like this change is no longer needed or has been superseded. Abandoning to clean out the review queue. Feel free to restore if this is not the case, and this is still a change that is actively being worked upon. Thanks!

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Dickinson (<email address hidden>) on branch: master
Review: https://review.openstack.org/192960
Reason: Abanoning based on the lack of activity since the last negative review. If you want to continue working on this, please reopen this patch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/302070

[OpenStack Infra (hudson-openstack)]

Change abandoned by Nikhil Manchanda (<email address hidden>) on branch: master
Review: https://review.openstack.org/302070
Reason: Abandoning for now