ratelimit use wrong HTTP error code (should be 429, not 498)

Bug #1099365 reported by Donagh McCabe
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Won't Fix
Undecided
Unassigned

Bug Description

According to http://tools.ietf.org/html/rfc6585 the appropriate error code for a container being rate-limited is 429, not 498.

This RFC post-dates when the ratelimit middleware was written, hence the missmatch.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/19617

Changed in swift:
status: New → In Progress
Revision history for this message
Chuck Thier (cthier) wrote :

Rate limiting in swift was implemented before the above rfc was proposed. Changing the rate-limit in the current API would break clients, and so would not be advisable. We have started collecting things like this on the following page that we could implement in the next rev (possibly v1.1) of the API.

http://wiki.openstack.org/SwiftNextAPI

Revision history for this message
Samuel Merritt (torgomatic) wrote :

Closing as wontfix since we can't do it without a breaking API change. The change is noted on the referenced wiki page, though, so this bug isn't needed any more.

Changed in swift:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.