unhandled exception

Bug #770729 reported by Matthias Klose on 2011-04-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Svammel (UNMAINTAINED)
Undecided
Mattias Backman

Bug Description

DEBUG:Svammel:Getting ubuntu distribution.
DEBUG:Svammel:Getting archive test-rebuild-20110413.
DEBUG:Svammel:Got archive test-rebuild-20110413.
INFO:Svammel:Checking for successful builds for package debian-installer version >= 20101020ubuntu28
Traceback (most recent call last):
  File "file-failures.py", line 163, in <module>
    (log_entry.package_name, log_entry.package_version))
  File "/home/doko/lp/svammel/data_parsing.py", line 201, in exists_successful_later_build
    fail_build_date = fail_build_record.datecreated
AttributeError: 'NoneType' object has no attribute 'datecreated'

Related branches

Matthias Klose (doko) wrote :

worked around with:

@@ -197,6 +198,8 @@

 def exists_successful_later_build(spph, archives, fail_arch):
     fail_build_record = spph.get_arch(fail_arch)
+ if fail_build_record == None:
+ return None
     fail_build_date = fail_build_record.datecreated
     for archive, archive_name in archives:
         # Get list of successful builds for the same package

Mattias Backman (mabac) wrote :

This situation occurred in the clean up phase, after bug filing. The script found a bug in the log file and goes ahead to check if there is a more recent successful build, in which case the old bug should be closed.

This did fail because the script hadn't found the old build failure during the bug filing phase. I guess the failed build is no longer in the archive if the build is re-run and succeeds? If so, the script needs to handle that.

Matthias Klose (doko) wrote :

hmm, that was a run with python file-failures.py --archive=test-rebuild-20110413 --logfile=20110413.state --importance=High -v
so maybe the debian-installer build was rescheduled. hte state/logfile had this as already filed as bug #766038

Mattias Backman (mabac) wrote :

I fixed this in the linked branch by accepting that even if no build failure is found, a successful build may be searched for. This is needed for closing bugs that have been recorded in the log file after the build failure is no longer available.

Mattias Backman (mabac) on 2011-04-28
Changed in svammel:
assignee: nobody → Mattias Backman (mabac)
milestone: none → 0.1.1
status: New → In Progress
Mattias Backman (mabac) on 2011-04-28
Changed in svammel:
status: In Progress → Fix Committed
Mattias Backman (mabac) on 2011-06-01
Changed in svammel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers