Sunbeam Charms

coverage omits unittest python files

Bug #2050839 reported by Samuel Allan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sunbeam Charms
Fix Committed
Undecided
Samuel Allan

Bug Description

coverage should always include unittest files. It's important to include to catch dead code, duplicate named functions, etc. in tests. Test files should be expected to have almost 100% coverage.

Tags: in-main
Revision history for this message
Samuel Allan (samuelallan) wrote :

Opened patch: https://review.opendev.org/c/openstack/sunbeam-charms/+/906336

This uncovered some unused code within test files, so appears to be a win. A follow up can be done to remove all the unused code. :)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sunbeam-charms (main)

Reviewed: https://review.opendev.org/c/openstack/sunbeam-charms/+/906336
Committed: https://opendev.org/openstack/sunbeam-charms/commit/610443f95039351dee75ba46db15d5d921fcaeb7
Submitter: "Zuul (22348)"
Branch: main

commit 610443f95039351dee75ba46db15d5d921fcaeb7
Author: Samuel Allan <email address hidden>
Date: Tue Jan 23 15:47:31 2024 +1030

    Include unit test methods in coverage

    It's important to include unittests in coverage,
    to detect things like unused code or shadowed methods.

    Closes-Bug: #2050839

    Change-Id: Ibee587af7892e8db13fb9564e05b0eccf56c6425

tags: added: in-main
Samuel Allan (samuelallan)
Changed in sunbeam-charms:
status: New → Fix Committed
assignee: nobody → Samuel Allan (swalladge)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.