[PATCH] Fail the certificate verification in subvertpy.ra.get_ssl_server_trust_prompt_provider

[Mitsuhiro Koga]

To fail to validate the certificate is in subvertpy.ra.get_ssl_server_trust_prompt_provider
it is necessary to null the svn_auth_cred_ssl_server_trust_t.

subversion corresponds to line 327 of the following sources.
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/prompt.c?revision=1295006&view=markup

The attached patch fails the validation of certificates when the function that is handling the return of None.

[Jelmer Vernooij (jelmer)]

Thanks for the patch, I'll have a look at merging this.

[Jelmer Vernooij (jelmer)]

Thanks again for the patch, and sorry for taking so long to get back to you.

The testsuite fails for me with your patch applied. The test you added fails:

======================================================================
ERROR: test_server_untrust (subvertpy.tests.test_ra.AuthTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "subvertpy/tests/test_ra.py", line 440, in test_server_untrust
    self.assertEquals(None, creds.next())
StopIteration: No more credentials available

[Mitsuhiro Koga (shiena-jp)]

Thank you for check. I was fixed test.
This is a test validation fails, creds was empty.

[Jelmer Vernooij (jelmer)]

On Wed, May 08, 2013 at 05:48:28PM -0000, Mitsuhiro Koga wrote:
> Thank you for check. I was fixed test.
> This is a test validation fails, creds was empty.
>
>
> ** Patch added: "fix_test.diff"
> https://bugs.launchpad.net/subvertpy/+bug/1059821/+attachment/3670014/+files/fix_test.diff
>
Thanks, merged.

Cheers,

Jelmer