TestResultDecorator.tags is a buggy copy-paste of .time

Bug #681828 reported by Jonathan Lange
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
subunit
Fix Released
Critical
Jonathan Lange

Bug Description

e.g.

Traceback (most recent call last):
  File "tests-with-output.py", line 69, in <module>
    sys.exit(main())
  File "tests-with-output.py", line 62, in main
    protocol.lineReceived(line)
  File "/home/jml/src/subunit/trunk/python/subunit/__init__.py", line 503, in lineReceived
    self._state.lineReceived(line)
  File "/home/jml/src/subunit/trunk/python/subunit/__init__.py", line 234, in lineReceived
    self.parser._handleTags(offset, line)
  File "/home/jml/src/subunit/trunk/python/subunit/__init__.py", line 490, in _handleTags
    self.client.tags(new_tags, gone_tags)
  File "/usr/lib/python2.6/dist-packages/testtools/testresult/real.py", line 517, in tags
    return method(new_tags, gone_tags)
  File "/home/jml/src/subunit/trunk/python/subunit/test_results.py", line 85, in tags
    return self.decorated.time(new_tags, gone_tags)
TypeError: time() takes exactly 2 arguments (3 given)

See the actual method:

    def tags(self, new_tags, gone_tags):
        return self.decorated.time(new_tags, gone_tags)

    def time(self, a_datetime):
        return self.decorated.time(a_datetime)

Related branches

Jonathan Lange (jml)
Changed in subunit:
status: New → Triaged
importance: Undecided → Critical
status: Triaged → In Progress
assignee: nobody → Jonathan Lange (jml)
Jonathan Lange (jml)
Changed in subunit:
status: In Progress → Fix Committed
Revision history for this message
Graham Binns (gmb) wrote :

Looks like this has been released for a while.

Changed in subunit:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.