Please provide information how to include local modifications into subiquity-test.snap

Bug #2039966 reported by Josef Wolf
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
subiquity
Fix Released
Undecided
Olivier Gayot

Bug Description

README.md states that changes can be tested via

  snapcraft snap --output subiquity_test.snap

Unfortunately, this don't seem to be enough when changes are made to some sub-component (e.g. curtin). My local modifications don't show up in the generated subiquity_test.snap.

  snapcraft pull curtin

also won't help (this probably pulls the original git repo?)

BTW: snapcarft emits a warning: "The 'snap' command is deprecated, use 'pack' instead."

Olivier Gayot (ogayot)
Changed in subiquity:
assignee: nobody → Olivier Gayot (ogayot)
status: New → In Progress
Revision history for this message
Olivier Gayot (ogayot) wrote :

Hello Josef,

I opened https://github.com/canonical/subiquity/pull/1846 to clarify how to proceed with changes in curtin. Please feel free to try out and revert to us if you run into more issues.

Thanks,
Olivier

Revision history for this message
Josef Wolf (jw-raven) wrote :

Yes, this works! Thanks a lot!

But please add a note that the FULL SHA is needed. Using only a shortened SHA (as printed by git-commit) results in a crash.

Revision history for this message
Olivier Gayot (ogayot) wrote :

Note added and change merged, thanks!

Changed in subiquity:
status: In Progress → Fix Committed
Olivier Gayot (ogayot)
Changed in subiquity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.