subiquity crash when installing with virtualbox TPM

[fossfreedom]

Using virtualbox 7 EFI + secure boot + ubuntu-budgie-installer

Chose the experimental TPM encryption option - press Next which showed he snap recovery instructions.

However the next button doesnt do anything.

Looked at journalctl and saw that there was an unhandled subiquity issue

nstaller.desktop[3110]: flutter: DEBUG subiquity_client: POST http://localhost/storage/v2/guided
nstaller.desktop[3110]: flutter: ERROR ubuntu-budgie-installer: Unhandled exception
nstaller.desktop[3110]: SubiquityException: setGuidedStorageV2({"target":{"disk_id":"disk-sda","allowed":["DIRECT","LVM","LVM_LUKS","Z>
nstaller.desktop[3110]: Traceback (most recent call last):
nstaller.desktop[3110]: File "/snap/ubuntu-budgie-installer/29/bin/subiquity/subiquity/common/api/server.py", line 164, in handler
nstaller.desktop[3110]: result = await implementation(**args)
nstaller.desktop[3110]: File "/snap/ubuntu-budgie-installer/29/bin/subiquity/subiquity/server/controllers/filesystem.py", line 1152, in>
nstaller.desktop[3110]: await self.guided(data)
nstaller.desktop[3110]: File "/snap/ubuntu-budgie-installer/29/bin/subiquity/subiquity/server/controllers/filesystem.py", line 685, in >
nstaller.desktop[3110]: self.set_info_for_capability(choice.capability)
nstaller.desktop[3110]: File "/snap/ubuntu-budgie-installer/29/bin/subiquity/subiquity/server/controllers/filesystem.py", line 674, in >
nstaller.desktop[3110]: raise Exception("could not find variation for {}".format(capability))
nstaller.desktop[3110]: Exception: could not find variation for GuidedCapability.CORE_BOOT_ENCRYPTED
nstaller.desktop[3110]: #0 SubiquityClient._receive (package:subiquity_client/src/client.dart:72)
nstaller.desktop[3110]: <asynchronous suspension>
nstaller.desktop[3110]: #1 StorageService.setGuidedStorage (package:ubuntu_bootstrap/services/storage_service.dart:91)

tarball of /var/log/installer enclosed

ProblemType: Bug
DistroRelease: Ubuntu 23.10
Package: subiquity (unknown)
ProcVersionSignature: Ubuntu 6.5.0-5.5-generic 6.5.0
Uname: Linux 6.5.0-5-generic x86_64
NonfreeKernelModules: zfs
ApportVersion: 2.27.0-0ubuntu2
Architecture: amd64
CasperMD5CheckResult: pass
CasperVersion: 1.482
CurrentDesktop: Budgie:GNOME
Date: Sun Sep 24 22:26:35 2023
LiveMediaBuild: Ubuntu-Budgie 23.10 "Mantic Minotaur" - Beta amd64 (20230924)
ProcEnviron:
 LANG=C.UTF-8
 PATH=(custom, no user)
 SHELL=/bin/bash
 TERM=xterm-256color
 XDG_RUNTIME_DIR=<set>
SourcePackage: subiquity
UpgradeStatus: No upgrade log present (probably fresh install)

[Michael Hudson-Doyle (mwhudson)]

2023-09-24 22:23:24.269117 DEBUG subiquity_client: ==> getGuidedStorageV2(true) {"status": "DONE", "error_report": null, "configured": null, "targets": [{"disk_id": "disk-sda", "allowed": ["DIRECT", "LVM", "LVM_LUKS", "ZFS"], "disallowed": [], "$type": "GuidedStorageTargetReformat"}, {"allowed": ["MANUAL"], "disallowed": [], "$type": "GuidedStorageTargetManual"}]}

The client should not have shown you the TPM encryption option in this case (it doesn't look as if the ISO even suports this as an option).

[fossfreedom (fossfreedom)]

Hi @mwhudson

Interesting! So is this ubuntu-desktop-provision ignoring the return values from subiquity? Should I raise an issue on github?

If a flavour wants to also have experimental TPM support what extra does a flavour need to do? Seed change? livecd-rootfs change?

[Oliver Smith (local-optimum)]

Hey @fossfreedom,

I'll let @dbungert chime in on the subiquity values issue, but regarding flavour support for TPM FDE, there is some work we would need to do on our side to help create the correct models to support it. We're happy to do this and want to ensure the flavours can take advantage of this feature, but currently we're rather resource constrained on ensuring we have everything in place to broaden our hardware compatibility and deal with issues raised in testing. I worry broadening the matrix of potential scenarios would be unwise at this stage.

I think flavour support is something we need to build into our roadmap going into 24.04 LTS once we're closer to being able to remove the 'experimental' flag on the feature and not something we'd be able to provide for mantic. After release we can coordinate more on what's needed on both sides.

[Dan Bungert (dbungert)]

> So is this ubuntu-desktop-provision ignoring the return values from subiquity?

It was in this very narrow case and was showing the TPMFDE checkbox unconditionally. That's fixed though on the Desktop dailies since beta.

> Should I raise an issue on github?

Please confirm that you have the latest ubuntu-desktop-provision. I know there was a hiccup there as we were picking a plan for source code branches but I think that's sorted out now. If that's still happening then I think that's a ubuntu-desktop-provision discussion.

[fossfreedom (fossfreedom)]

https://github.com/UbuntuBudgie/ubuntu-budgie-installer/commit/1b38fabbd8c1096f2c05e5cb4a92a156a4655436

the above is the current version that dependabot has updated our installer. I promoted that version before testing.

[fossfreedom (fossfreedom)]

raised https://github.com/canonical/ubuntu-desktop-provision/issues/150

[fossfreedom (fossfreedom)]

Enclosed an updated /var/log/installer logs for ubuntu-budgie 22.04 release candidate - issue still occurs with virtualbox 7.0 EFI, secure boot with TPM v2.0

[Ubuntu QA Website (ubuntuqa)]

This bug has been reported on the Ubuntu ISO testing tracker.

A list of all reports related to this bug can be found here:
http://iso.qa.ubuntu.com/qatracker/reports/bugs/2037234