Sorting disks by label is a bad default

[Henry Farnsworth]

If I'm reading the source correctly[1], the disks list is currently sorted by label. Since the content of the label is completely arbitrary I think this is a poor default to sort on.

For virtio disk you may work around this by manipulating the disk serial, but still I think this is a poor way to sort the list.

I'd say sorting by kernel name, or even pci path would be more predictable.

[1] https://github.com/CanonicalLtd/subiquity/blob/a8b9a42c21c411031cf9c5941f967ef6666e7164/subiquity/models/filesystem.py#L1691

[Michael Hudson-Doyle (mwhudson)]

Well we sort by label because we display the label as the primary way of identifying the drive, although I agree the label can be inscrutable at times. Sorting by some field that isn't shown seems worse though.