subiquity must generate vtoc partition tables for DASD drives

Bug #1847073 reported by Dimitri John Ledkov on 2019-10-07
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu on IBM z Systems
High
Unassigned
subiquity
High
Unassigned
curtin (Ubuntu)
Critical
Ryan Harper

Bug Description

on s390x tries to create GPT table on dasd drive, instead of DOS

/dev/dasd[a-z] drives only support upto 3 partitions, and thus one must use DOS partition table on them, not GPT.

Related branches

Ryan Harper (raharper) wrote :

Something like so:

storage:
    version: 1
    config:
      - id: dasd_spare
        type: dasd
        device_id: 0.0.1520
        blocksize: 4096
        mode: full
        disk_layout: cdl
      - id: sda
        type: disk
        wipe: superblock
        ptable: msdos
        model: QEMU HARDDISK
        serial: disk-a
        grub_device: true

Michael Hudson-Doyle (mwhudson) wrote :

Oh man, there goes my dream of pretending the One True partition table was gpt.

If they only support three partitions, then it's not really a DOS partition table either, is it?

We'll also need UI changes to enforce the three partition limit I guess.

Ryan Harper (raharper) wrote :

Actually, this isn't right; For DASD, we need to specify 'vtoc'.

storage:
    version: 1
    config:
      - id: dasd_001520
        device_id: 0.0.1520
        blocksize: 4096
        mode: full
        disk_layout: cdl
        type: dasd
      - id: dasdb
        type: disk
        ptable: vtoc
        serial: 0X1520
        device_id: 0.0.1520
        wipe: superblock

Ryan Harper (raharper) wrote :

The example config and docs don't mention VTOC; the mention of MBR and DOS is not correct at all. The curtin dasd code, checks for vtoc; which currently will fail schema validation; I'll put up a branch to fix docs and schema for curtin right now.

Changed in curtin (Ubuntu):
importance: Undecided → Critical
Dimitri John Ledkov (xnox) wrote :

Indeed it's not "dos" but something special. But i.e. d-i did dasdfmt in a separate component and then pretended it's dos later and things kind of worked.

Dimitri John Ledkov (xnox) wrote :

(anyway, curtin has support for dasdfmt'ing the drives, and creating partitions on it, we "just" need to create the valid storage config for it)

summary: - on s390x tries to create GPT table on dasd drive, instead of DOS
+ subiquity does not generate correct config for DASD drives
tags: added: dasd
Changed in curtin (Ubuntu):
status: New → Triaged
status: Triaged → In Progress
assignee: nobody → Ryan Harper (raharper)

This bug is fixed with commit 12b437d8 to curtin on branch master.
To view that commit see the following URL:
https://git.launchpad.net/curtin/commit/?id=12b437d8

Frank Heimes (fheimes) wrote :

just to confirm, vtoc is correct, see:
dasdview -t info /dev/dasda
fdasd -p /dev/dasda
or their respective man pages

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package curtin - 19.2-44-g8e618b34-0ubuntu1

---------------
curtin (19.2-44-g8e618b34-0ubuntu1) focal; urgency=medium

  * New upstream snapshot.
    - t/jenkins-runner: replace $EPOCHSECONDS with 'date +%s' [Paride Legovini]
    - curthooks: skip setup_kernel_img_conf on eoan and newer (LP: #1847257)
    - block_meta: use lookup for wwn, fix fallback from wwn, serial, path
      (LP: #1849322)
    - vmtest: Adjust TestScsiBasic to use dnames to find correct disk
    - schema: Add ptable value 'unsupported' (LP: #1848535)
    - tools/xkvm: add -nographic to speed up devopt query
    - test_block_dasd: fix random_device_id to only generate valid IDs
      (LP: #1849549)
    - vmtest: update skip_if_arch message
    - Add skip_by_date to eoan ipv6 vlan test
    - storage_config: interpret value, not presence, of
      DM_MULTIPATH_DEVICE_PATH [Michael Hudson-Doyle]
    - vmtest: Add skip_by_date for test_ip_output on eoan + vlans
    - block-schema: update raid schema for preserve and metadata
    - dasd: update partition table value to 'vtoc' (LP: #1847073)
    - clear-holders: increase the level for devices with holders by one
      (LP: #1844543)
    - tests: mock timestamp used in collect-log file creation (LP: #1847138)
    - ChrootableTarget: mount /run to resolve lvm/mdadm issues which
      require it.
    - block-discover: handle multipath disks (LP: #1839915)
    - Handle partial raid on partitions (LP: #1835091)
    - install: export zpools if present in the storage-config (LP: #1838278)
    - block-schema: allow 'mac' as partition table type (LP: #1845611)
    - jenkins-runner: disable the lockfile timeout by default [Paride Legovini]
    - curthooks: use correct grub-efi package name on i386 (LP: #1845914)
    - vmtest-sync-images: remove unused imports [Paride Legovini]
    - vmtests: use file locking on the images [Paride Legovini]
    - vmtest: enable arm64 [Paride Legovini]
    - Make the vmtests/test_basic test suite run on ppc64el [Paride Legovini]
    - vmtests: separate arch and target_arch in tests [Paride Legovini]
    - vmtests: new decorator: skip_if_arch [Paride Legovini]
    - vmtests: increase the VM memory for Bionic
    - vmtests: Skip Eoan ZFS Root tests until bug fix is complete
    - Merge branch 'fix_merge_conflicts'
    - util: add support for 'tbz', 'txz' tar format types to sanitize_source
      (LP: #1843266)
    - net: ensure eni helper tools install if given netplan config
      (LP: #1834751)
    - d/control: update Depends for new probert package names
      [Dimitri John Ledkov]

 -- Ryan Harper <email address hidden> Fri, 01 Nov 2019 14:06:13 -0500

Changed in curtin (Ubuntu):
status: In Progress → Fix Released
Changed in subiquity:
importance: Undecided → High
status: New → Triaged
summary: - subiquity does not generate correct config for DASD drives
+ subiquity must generate vtoc partition tables for DASD drives
Frank Heimes (fheimes) on 2019-11-14
Changed in ubuntu-z-systems:
status: New → Triaged
importance: Undecided → High
tags: added: installer
Frank Heimes (fheimes) on 2019-12-09
tags: added: req4focal
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers