/etc/fstab: fs_passno is 0 for all file systems

[Tom Reynolds]

Using the 18.04.1 server-live installer with manual partition, the system ends up with an fstab like this:

UUID=d94e7ea3-9785-11e8-b625-080027681a6b / ext4 defaults 0 0
UUID=d94e7ea2-9785-11e8-b625-080027681a6b /boot ext4 defaults 0 0
/swap.img none swap sw 0 0

fs_passno is is 0 for all file systems. fstab(5), however, states:

       The sixth field (fs_passno).
       ...
       The root filesystem should be specified with a fs_passno of 1.
       Other filesystems should have a fs_passno of 2.

http://manpages.ubuntu.com/manpages/bionic/en/man5/fstab.5.html#description

Related bugs:
 * bug 1779207: Failed mount of '/dev/sdb1' with Swap File cloud-init config

[Michael Hudson-Doyle (mwhudson)]

Pretty sure this is curtin too.

[Ryan Harper (raharper)]

Curtin supports specifying this information in the mount structure (mount documentation needs an update to indicate we support specifying any of the mount fields in fstab (spec, fstype, path, freq and passno).

- type: mount
  id: sda1_mount
  path: /
  device: sda1_root
  passno: 1

Curtin could change the default the passno value for mount entries which have path == "/" to 1 for passno and 2 for other mounts that are not root. There are some restrictions that need to be handled, for example, no need to fsck enable bind and tmpfs mounts.

The other concern here (for curtin in general) is whether we want to enable fsck on the partitions which historically have never had fsck enabled.

[Tom Reynolds (tomreyn)]

I'd like to point out that, at least (maybe not only?) from a user perspective, this is a regression when comparing to both the previous (16.04.x) LTS (d-i) server installer and the 18.04.x alternative (d-i) server installer.