Extra option to show uploader in the subtitle filename

Bug #628901 reported by Ivan Garcia on 2010-09-02
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
SubDownloader
Wishlist
Marco Rodrigues

Bug Description

When multiple subtitles exist for the same movie, it would be nice to be able to do name the subtitles like this: moviefilename.languageXXX.uploader.srt

For now I accomplished it by doing this:

elif optionSubtitleName == QVariant("SAME_VIDEOPLUSLANG"):
           subFileName = without_extension(video.getFileName()) +"." +subtitle.getLanguageXXX() +"." +subtitle.getUploader()+"." + sub_extension

A more proper configurable solution would be nice.

Ivan Garcia (capiscuas) wrote :

Thanks,

if you go deeper and can configure the QT part that would be awesome.

BTW, what is the interest to show also the uploader in the filename?

  I would like the uploader to be shown since that helps identify the
good subtitles. This way you know whose subtitles to prefer for later
episodes. Also it makes it easier to download more subtitles for the
same episode should one of them turn out to be of poor quality.

I will try to make the required changes, but I must warn you that I have
never written anything i Python.

/Jeppe

On 02-09-2010 17:30, Ivan Garcia wrote:
> Thanks,
>
> if you go deeper and can configure the QT part that would be awesome.
>
> BTW, what is the interest to show also the uploader in the filename?
>

Jeppe Dam (jeppedam) wrote :

Here is my attempt to implement this feature.
Note that I am a newbie at Python and Bazar, but it seems to work as intended.

Marco Rodrigues (gothicx) wrote :

Could you update patch to apply to current trunk version?

Thank you

Changed in subdownloader:
status: New → In Progress
assignee: nobody → Marco Rodrigues (gothicx)
Jeppe Dam (jeppedam) wrote :

Here is an updated patch

Marco Rodrigues (gothicx) wrote :

It doesn't apply cleanly in gui/preferences.ui, could you fix it please?

Thanks

Jeppe Dam (jeppedam) wrote :

Here is another try. I am quite newbie with this bazaar thing. I cleaned the patch up a lot, so it should be much less changes in the problematic file now.

Marco Rodrigues (gothicx) wrote :

It worked. I'll apply it to the trunk.

Thank you

Changed in subdownloader:
milestone: none → 2.0.15
status: In Progress → Fix Committed
Changed in subdownloader:
importance: Undecided → Wishlist
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers