detect_software_updates crash

[Jan Klepek]

Version:
2.0.9.3
Linux / Fedora 11

How to reproduce:
when starting from command line:
/usr/lib/python2.6/site-packages/subdownloader/modules/subtitlefile.py:21: DeprecationWarning: the md5 module is deprecated; use hashlib instead
  import md5
[17:48] ERROR::subdownloader.SDService.SDService # Unable to connect. Try setting a proxy.
Unhandled exception in thread started by <bound method Main.detect_software_updates of <gui.main.Main object at 0x28b2f30>>
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/subdownloader/gui/main.py", line 548, in detect_software_updates
    result = self.SDDBServer.CheckSoftwareUpdates('SubDownloader')
  File "/usr/lib/python2.6/site-packages/subdownloader/modules/SDService.py", line 676, in CheckSoftwareUpdates
    return CheckSoftwareUpdates(app)
  File "/usr/lib/python2.6/site-packages/subdownloader/modules/SDService.py", line 74, in __call__
    result = self.function(*args)
  File "/usr/lib/python2.6/site-packages/subdownloader/modules/SDService.py", line 686, in _CheckSoftwareUpdates
    info = self.xmlrpc_server.CheckSoftwareUpdates(app)
AttributeError: 'NoneType' object has no attribute 'CheckSoftwareUpdates'

Possible fix:
uncommenting try/catch block is working as fix, see attached patch

Comment:
For Fedora distribution I will disable checking for subdownloader updates. As updates will be distributed by yum when there will be new version.

[Kapis (capiscuas)]

Thks a lot, i've applied the patch in the bzr.

The connection problem was due to our django server was down.

Best Regards.
Ivan.