GUI doesn't report network errors clearly
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
SubDownloader |
Confirmed
|
Medium
|
Unassigned |
Bug Description
After I have SD open for a long time, upload operations fail with a generic message along the lines of "network connection error, try again later". Simply trying again doesn't help, but logging out and back in does.
The console shows a traceback:
Traceback (most recent call last):
File "/home/
results = self._main.
File "/home/
return TryUploadSubtit
File "/home/
result = self.function(
File "/home/
else:
KeyError: 'alreadyindb'
I dug a little into the code - the value of result at this point is {'status': '401 Unauthorized', 'token': 'hselggjokb4qfe
The whole SDService.py file seems to handle errors poorly:
1. some errors are caught, written to the log and *ignored* - functions silently return None, etc.
2. XMLRPC status is never checked, it's just assumed to be 200.
I can imagine many other situations where it wouldn't report failures properly to the user.
- Version: 2.0.10 (bzr trunk actually)
- OS: Linux (ubuntu Jaunty)
Changed in subdownloader: | |
importance: | Undecided → Medium |
status: | New → Confirmed |