disable auto-detect language when i'm uploading subtitle

Bug #247061 reported by Tigerroad
4
Affects Status Importance Assigned to Milestone
SubDownloader
Fix Released
Undecided
Kapis

Bug Description

Upload subtitles: When selecting a Danish subtitle with sub-extension da ex. "rcdivx-ypfuck.da.srt" the language in dropdownbox is set to Norwegian instead of Danish

Tags: gui
Revision history for this message
Tigerroad (mathiaschr) wrote :
Kapis (capiscuas)
Changed in subdownloader:
assignee: nobody → mferreira
Revision history for this message
Kapis (capiscuas) wrote :

The danish subtitles contains so little information that the dannish.lm file, (check the libtextcat project) confuses with the norwegian language.

There are 2 solutions here:

-Whether you create a better dannish.lm fingerprints (use the createfp project) that will work the majority of subtitles.
-if you select "upload language" in preferences, it should have more priority than the autodetect language by fingerprints.(this to be implemented)

Changed in subdownloader:
status: New → Confirmed
assignee: mferreira → capiscuas
Revision history for this message
Kapis (capiscuas) wrote :

I've changed the name of the bug to also cover this request (which happens with Portuguese/ Brazilian)
http://forum.opensubtitles.org/viewtopic.php?t=381

Revision history for this message
Tigerroad (mathiaschr) wrote :

The "upload language" in preferences doesn't seem to have higher priority that the autodetect function. Why not implement check of filename first.. So that if people name their files with language code like rcdivx-ypfuck.da.srt or rcdivx-ypfuck.no.srt the right language is selected. And if no language code is present the autodetect by fingerprint is used

Revision history for this message
Kapis (capiscuas) wrote :

Hi tigerroad:

let me complete your suggestion and make it clear to see if you agree with this:

- 1st priority: If Upload Language in preferences is not "AutoDetect" but some language X -> use language X always
- 2nd priority: If preferences = AutoDetect , then if filename has language code, ex: rcdivx-ypfuck.da.srt -> Detect Danish language
- 3rd priority: language autodetected by OSDB server
- 4rd priority: language autodetected by content guess (not effective for the case of Danish-Norwegian)

Kapis (capiscuas)
Changed in subdownloader:
status: Confirmed → Fix Committed
Revision history for this message
Tigerroad (mathiaschr) wrote :

That would be very nice indeed. I strongly agree :-)

Kapis (capiscuas)
Changed in subdownloader:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.