failure to build due to deprecated declarations

Bug #2029877 reported by Vladimir Petko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
strongSwan
New
Unknown
network-manager-strongswan (Debian)
Fix Released
Unknown
network-manager-strongswan (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

See https://launchpadlibrarian.net/677164396/buildlog_ubuntu-mantic-amd64.network-manager-strongswan_1.6.0-2_BUILDING.txt.gz

Patching deprecation results in a large patch with potential regression due to changes in FileChooser API[1].

Until the issue is fixed upstream we can disable deprecation warnings for this package.

[1] https://docs.gtk.org/gtk4/method.FileDialog.open_finish.html

Related branches

Vladimir Petko (vpa1977)
tags: added: update-excude
tags: added: update-excuse
removed: update-excude
Vladimir Petko (vpa1977)
description: updated
description: updated
Revision history for this message
Vladimir Petko (vpa1977) wrote :
Revision history for this message
Simon Quigley (tsimonq2) wrote :

The patch makes me slightly uncomfy, given that we should work to fix the warnings instead of disable them, but simply disabling deprecation warnings when both Debian and upstream have been made aware is okay for now.

Changed in network-manager-strongswan (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package network-manager-strongswan - 1.6.0-2ubuntu1

---------------
network-manager-strongswan (1.6.0-2ubuntu1) mantic; urgency=medium

  * d/rules: fix ftbfs by disabling GTK deprecation warnings (LP: #2029877).

 -- Vladimir Petko <email address hidden> Fri, 04 Aug 2023 12:16:48 +1200

Changed in network-manager-strongswan (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Vladimir Petko (vpa1977) wrote (last edit ):

Upstream replied that they will not rewrite code for gtk4 due to compatibility with gtk3.

Revision history for this message
Simon Quigley (tsimonq2) wrote :

The response upstream gave sounds pretty reasonable. Let's continue with this patch, barring any objections or alternative solutions from Debian.

Thanks again for your work on this, Vladimir. :)

Changed in strongswan:
status: Unknown → New
Changed in network-manager-strongswan (Debian):
status: Unknown → New
Changed in network-manager-strongswan (Debian):
status: New → Fix Released
Revision history for this message
Harri-afaics (harri-afaics) wrote :

Please consider adding a marge request on Salsa, as usual. Thank you

Revision history for this message
Vladimir Petko (vpa1977) wrote (last edit ):

I have submitted the debdiff to the existing Debian bug[1] that was fixed in 1.6.0-2.1.
I will add the MRs where possible in the future.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1042044

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.