Automatically disconect users who leave the hub doesn't work on svn462

Bug #439548 reported by eMTee
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StrongDC++
Confirmed
Undecided
Unassigned

Bug Description

Maybe its a known transient bug between two releases, if so just make it Invalid :)

[2009-09-22 19:48] <eMTee> make sure you don't have me on the fav users
[2009-09-22 19:49] <Pirre> removed
[2009-09-22 19:49] <eMTee> if you don't have it enabled, enable 'Automatically disconect users who leave the hub'
[2009-09-22 19:49] <Pirre> its enabled
[2009-09-22 19:49] <eMTee> k
[2009-09-22 19:50] <Pirre> but thik thats broken
[2009-09-22 19:50] <eMTee> I think so
[2009-09-22 19:50] <eMTee> I'll start download from you then leave
[2009-09-22 19:51] *** User went offline
[2009-09-22 19:51] *** User went online [Pirre - MP3 Rock Hub] ***
[2009-09-22 19:51] <eMTee> ok so it doesnt work
[2009-09-22 19:52] <eMTee> thanks
[2009-09-22 19:52] <Pirre> the timout is about 1 minut
[2009-09-22 19:52] <eMTee> what timeout?
[2009-09-22 19:52] <Pirre> i mean the disconnect its not instant
[2009-09-22 19:52] <eMTee> should be
[2009-09-22 19:52] <eMTee> at least it is in DC++
[2009-09-22 19:52] <Pirre> have even seen 2 minuts in 2.22 before
[2009-09-22 19:52] <eMTee> ok lets see
[2009-09-22 19:53] *** User went offline
[2009-09-22 20:00] *** User went online [Pirre - MP3 Rock Hub] ***
[2009-09-22 20:01] <Pirre> disconnected user leaving the hub after 2 minuts and 30 sec
[2009-09-22 20:01] <Pirre> so it works but with delay. this is a 2.30
[2009-09-22 20:01] <eMTee> yeah but it did not work with hubfileserver
[2009-09-22 20:01] <Pirre> hmm, that's an svn462
[2009-09-22 20:02] <eMTee> that's what I am talking about
[2009-09-22 20:02] <Pirre> hmm... there it uploaded like 30 files to a offline user
[2009-09-22 20:02] <Pirre> let me see the setting's enabled there
[2009-09-22 20:02] <eMTee> yeah check it pls
[2009-09-22 20:03] <Pirre> its enabled but doesnt work
[2009-09-22 20:04] <eMTee> ok so the problem is there. It worked for me before and I realized recently that it doesn't
[2009-09-22 20:05] <eMTee> so it muddled up between the 2.30 release and svn462 somewhere

Revision history for this message
Big Muscle (bigmuscle) wrote :

It seems that same bug is also in DC++ (and all its derivation) - FLAG_PENDING_KICK is set per file (not per user/connection), so when user manages to download file before timeout and new file begins, it will be without FLAG_PENDING_KICK and therefore it won't be disconnected.

Changed in strongdc:
status: New → Confirmed
Revision history for this message
eMTee (realprogger) wrote :

Just tested with the latest DC++ bzr and it indeed works with. In fact it does not disconnect >at once< which can be a different (lower importance) bug. In this test case it needed 2-3 mins and several uploaded chunks before disconnect. But it disconnects and the message >Disconnected user xxx leave the hub< appears in the log.

Revision history for this message
Big Muscle (bigmuscle) wrote :

This feature isn't designed to disconnect immediately but there is a timeout (usually about 2 minutes) to give user a chance to return to hub without losing slot. And it seems to be working only if some chunk takes at least the time which is same as timeout. If each chunk/file takes lower time, it will never be disconnected, same in DC++. It should be fixed somehow.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.