Grant extra slot hangs connection in ADC hubs

Bug #305811 reported by Big Muscle
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DC++
Fix Released
Medium
Unassigned
DiCe!++
Fix Released
Undecided
Unassigned
StrongDC++
Fix Committed
Undecided
Unassigned

Bug Description

When granting slot to ADC user, DC++ tries to notify that user by sending connect command. But this causes connection to hang, because of token mismatch. Remote user will see upload connection for me, but there should be download connection.

Revision history for this message
Big Muscle (bigmuscle) wrote :

I have a suggestion about this bug. What about saving last used token to waiting users and use this one when notifying user with granted slot.

Big Muscle (bigmuscle)
Changed in strongdc:
status: New → Fix Committed
Revision history for this message
eMTee (realprogger) wrote :

bm, can you point us where and how did you fix this?

Changed in dcplusplus:
importance: Undecided → Medium
Revision history for this message
Big Muscle (bigmuscle) wrote :

I fixed it exactly in the way how I said in my previous post. When user is added to upload queue (waiting users list in DC++), the connection token is saved together with that user. When notifiying this user on "Reserve slot", the saved token is used instead of random one. Check UploadManager.cpp, function reserveSlot(...).

Revision history for this message
maksis (maksis) wrote :

Actually this hasn't been fully fixed in StrongDC.

When a passive user tries to start an upload from an active user, the active user doesn't set the token for an userconnection at all. This could be fixed by setting the token for incoming upload connections in ConnectionManager::on(AdcCommand::INF...

Changed in strongdc:
status: Fix Committed → New
Revision history for this message
Big Muscle (bigmuscle) wrote :

I set missing token for incoming connections as well as huburl in wx-rev76. I hope this fixes the problem.

Changed in strongdc:
status: New → Fix Committed
iceman50 (bdcdevel)
Changed in diceplusplus:
status: New → Fix Committed
Revision history for this message
iceman50 (bdcdevel) wrote :

Fix committed in DC++ r3017

Changed in dcplusplus:
status: New → Fix Committed
Revision history for this message
poy (poy) wrote :

Fixed in DC++ 0.800.

Changed in dcplusplus:
status: Fix Committed → Fix Released
iceman50 (bdcdevel)
Changed in diceplusplus:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.