Pathfinder Fix

[Andre Novellino Gouvêa]

Currently, we have the following code in astar.cpp (CostMoveToCallBack_Default function):

     // for non moving unit Always Fail unless goal is unit, or unit can attack the target
     if (&unit != goal) {
      if (goal->Player->IsEnemy(unit) && unit.IsAgressive() && CanTarget(*unit.Type, *goal->Type)
       && goal->Variable[UNHOLYARMOR_INDEX].Value == 0 && goal->IsVisibleAsGoal(*unit.Player)) {
        cost += 2 * AStarMovingUnitCrossingCost;
      } else {
      // FIXME: Need support for moving a fixed unit to add cost
       return -1;
      }
      //cost += AStarFixedUnitCrossingCost;
     }

The problem is that this makes melee units (or ranged units if the goal is outside range) keep trying to get to a target even if there is something blocking the way.

Modifying that code to this instead solves the issue:

     // for non moving unit Always Fail unless goal is unit, or unit can attack the target
     if (&unit != goal) {
      if (goal->Player->IsEnemy(unit) && unit.IsAgressive() && CanTarget(*unit.Type, *goal->Type)
       && unit.MapDistanceTo(*goal) <= unit.Variable[ATTACKRANGE_INDEX].Max
       && goal->Variable[UNHOLYARMOR_INDEX].Value == 0 && goal->IsVisibleAsGoal(*unit.Player)) {
        cost += 2 * AStarMovingUnitCrossingCost;
      } else {
      // FIXME: Need support for moving a fixed unit to add cost
       return -1;
      }
      //cost += AStarFixedUnitCrossingCost;
     }

[timfelgentreff (timfelgentreff)]

This project was moved to https://github.com/Wargus/stratagus. All issues were migrated there.