Cannot Connect for networked game

[Julio]

Somewhere between 8637 and 8677 I stopped being able to connect to play local network games.

Network game can be created, but unable to join from other machines.

8636 works okay, but the next revision I tried 8677 does not work... the problem persists in the latest 8720

I'm compiling on Mac OS X 10.8.3

[Julio (artofwar)]

Just a quick bump to let you know this still doesn't work as of the latest 8746.

Fresh build on OS X 10.8.3, no errors or warnings during compile.

[cybermind (iddqd-mail)]

I have this bug too, though I can connect on the localhost if I launch 2 instances of stratagus.exe each with different port using -P command line option

[cybermind (iddqd-mail)]

The bug-creating change was added in rev.8675. Will try to investigate the problem.

[Joris Dauphin (joris-dauphin)]

Little explanation:
In InitNetwork1(),
instead of trying to use a port in range CNetworkParameter::Instance.localPort + [0; 10[
we use only the one specified (CNetworkParameter::Instance.localPort).
(So if it is the server, its port is the one specified, and client don't have to guess which port in range is used).
If we can't use the port, an error message should be displayed on stderr.

This should affects only when using multiple instance on a single machine though...

[cybermind (iddqd-mail)]

Well, I've mistaken, the real problem is revision 8665, when UDP protocol handling was changed

[cybermind (iddqd-mail)]

Just tested it on network between Windows 2000 SP4 and Windows 7 SP1 and rev.8664 worked well whereas rev.8665 refused to join to game

[cybermind (iddqd-mail)]

Looks like i've fixed the bug, but the fix is ugly, need to fix it more correctly

[Joris Dauphin (joris-dauphin)]

I see you removed an usage of CNetworkParameter::Instance.localHost

I would say this var may be useful when computer has several network cards...
(but I'm not an expert).

The last usage of this variable is in master.cpp for TCP.
So, if you solution is correct,
Can you try if it is useful there and if not remove completely this var ?
I cannot test this network bug since I have only one machine (and previous code worked in that case :-/ ).
Thanks.

[Julio (artofwar)]

Just wanted to note that this appears to be fixed for me now.

Thanks cybermind!