Disconnection handling requires English locale

[Stuart Bishop]

is_disconnection_error currently sniffs the error message for strings to determine if an exception is a disconnection error. This fails when running PostgreSQL with a non-English locale.

Instead, we should check for more explicit exceptions or check the pgcode attribute on the error (error codes are documented at http://www.postgresql.org/docs/8.1/static/errcodes-appendix.html)

[James Henstridge (jamesh)]

Note that there is no pgcode attribute for disconnection errors: you only get those for errors reported from the database. By their nature, disconnection errors are reported when the client can't communicate with the database.

[Or at least this was the case back when I was writing the disconnection logic]

[Robert Collins (lifeless)]

On Wed, Sep 21, 2011 at 9:10 PM, James Henstridge
<email address hidden> wrote:
> Note that there is no pgcode attribute for disconnection errors: you
> only get those for errors reported from the database.  By their nature,
> disconnection errors are reported when the client can't communicate with
> the database.

From the linked page:
08000 CONNECTION EXCEPTION connection_exception
08003 CONNECTION DOES NOT EXIST connection_does_not_exist
08006 CONNECTION FAILURE connection_failure
08001 SQLCLIENT UNABLE TO ESTABLISH
SQLCONNECTION sqlclient_unable_to_establish_sqlconnection

Seem relevant.

_Rob

[Stuart Bishop (stub)]

Confirming jamesh's assertion. I've just tested connecting to a non existent server and terminating an active connection, and in both cases pgcode is None.